Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest clickhouse version #7

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Update to latest clickhouse version #7

merged 1 commit into from
Aug 20, 2024

Conversation

crisptrutski
Copy link
Contributor

This update is needed to resolve metabase/metabase#47007

@crisptrutski crisptrutski requested review from piranha, darksciencebase and a team August 20, 2024 13:57
@crisptrutski crisptrutski self-assigned this Aug 20, 2024
@crisptrutski crisptrutski added the bug Something isn't working label Aug 20, 2024
tsmacdonald
tsmacdonald approved these changes Aug 20, 2024
View reviewed changes
Copy link

@tsmacdonald tsmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers. Should we have a unit test?

@crisptrutski crisptrutski merged commit c91032a into main Aug 20, 2024
1 check passed
@crisptrutski crisptrutski deleted the crisptrutski-patch-1 branch September 4, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsmacdonald tsmacdonald tsmacdonald approved these changes

@piranha piranha Awaiting requested review from piranha

@darksciencebase darksciencebase Awaiting requested review from darksciencebase

Assignees

@crisptrutski crisptrutski

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSV uploads broken for Clickhouse when data contains datetime with offset
2 participants
@crisptrutski @tsmacdonald