Fix fallback to release-group cover art #3223
Open
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We havce some fallback mechanisms in place for cases where there is no release MBID available, but one check is currently too restrictive and prevents the fallback from triggering, for example for pseudo-releases with no cover art.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some fallback mechanisms in place for cases where there is no release MBID available, but one check is currently too restrictive and prevents the fallback from triggering, for example for pseudo-releases with no cover art.
If the use-submitted clean data with a release MBID and a release-group MBID, if the release does not have cover art it will currently not fall back to the release group cover art because we check if the user-submitted and the auto-mapped release MBIDs are equal.
If there is no mapped release the fallback will not trigger.