Break each replacement out of the update-content file and provide a system for writing more replacements #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: make help and arguments actually useful
fix: double quotes
Replacements
fix: keep default branch
Fix/replacements contract
|
Hey @tonygaetani, thanks for this, and sorry it's taken so long to be reviewed. There are a few small changes I'd like to make as there are changes in this PR (such as removing the default |
mheap
pushed a commit
that referenced
this pull request
Sep 16, 2020
…ystem for writing more replacements (#29) Co-authored-by: Harrison Muskat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've used this repo at 6 River Systems to migrate our default branches to
mainwhich has been great! Thank you so much @mheap for doing the heavy lifting here with this script!We added a replacement for circleci, if there is no circleci file in the repo then nothing happens.
We also changed how replacements happen, and made an extensible system for adding new replacements.
I've also done a bunch of work writing bash scripts to automatically update local git repos on development machines, that has been done in our internal tooling but if there is interest I can share some of the code and the lessons I've learned here as well