-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send metrics via any protocol in the OTLP Registry #5690
Comments
This comment was marked as duplicate.
This comment was marked as duplicate.
People who give this issue a 👍🏼 or 🚀, what is your use-case? Right now, the use-case seems to be sending the data through Kafka which is not supported by the specs if I remember correctly. But I'm curious if people have other use-cases or you are co-workers and has the same use-case. |
@jonatan-ivanov they are co-workers 😅 For the time being I did a local workaround for the issue. Let's see what the community might think of it |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Could people who wanted this feature please try out what we've delivered in 1.15.0-M2 and give feedback? See, for example, the added section in the documentation. There's a strong possibility this will change somewhat before the 1.15.0 GA release, and your feedback will help ensure we end up with a better feature in the end. |
See micrometer-metricsgh-5690 Signed-off-by: Johnny Lim <[email protected]>
See gh-5690 Signed-off-by: Johnny Lim <[email protected]>
We're still hoping for some feedback on this before GA if anyone can try it out and let us know what you think. |
Looks good on my end. Made my use of |
Looks like a great idea, maybe even one that could extend to other registries (i.e. make the export independent from the serialization)! |
I'm sure the nice folks on the Spring Boot team would consider it. I was waiting to get feedback on this and consider any additional changes before I asked them to change any auto-configuration for it.
You can always provide your own
I did consider doing that with this, but it hasn't really been asked for much in other registries and so I didn't want to expand the scope more than made sense. We can make this generic, but other registries would need to be updated to use it or else it wouldn't offer any benefit. Most other registries also tend to be a single protocol and format for the backend. Thus, most desired customization can be done via the long existing |
That makes sense to me. I think most registry autoconfigurations don't allow you to overwrite the HttpSender without creating a |
I've proposed a breaking API change to address this concern with the current API. Feel free to leave feedback on the PR or here if there is any concern with the changes. #5994 |
I've opened another PR for refining the API introduced for this - see #6025. |
Please describe the feature request.
The idea is to make it available for any consumer of the micrometer-otlp-registry to provide their own metrics sending implementation. The OTLP Registry can still only support HTTP/protobuf as it does today but, for example, its implementation can be described by a public interface.
Rationale
The purpose of the change is to allow for metrics sending to be more flexible on the consumer side. I'm not advocating any changed to the OTLP protocols, rather my intention would be to open metrics sending up.
And example on my end would be that I desire to push all metrics to a Kafka topic before they are sent via HTTP/protobuf to OTLP collector. This way I have greater control over my metrics that might be coming from a number of microservices.
Additional context
Slack discussion: https://micrometer-metrics.slack.com/archives/C01C4Q8FHC2/p1731676707725909
The text was updated successfully, but these errors were encountered: