add Array.prototype.filter signature with type guard

[maiermic]

10027 also didn't add the overload to Array#filter, only to ReadOnlyArray#filter. @mhegazy could you reopen this issue?

-- Arnavion's comment

This only adds it to ReadOnlyArray though. Also need it for regular Array.
-- Arnavion's comment

See #7657 and #10027

[msftclas]

Hi @maiermic, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

[mhegazy]

thanks @maiermic, some baslines changed, you will need to do a gulp baseline-accept

[mhegazy]

We will need to update the baselines as well. gulp baseline-accept will do the trick.

[maiermic]

@mhegazy Thanks, I appreciate your help.

[mhegazy]

waiting on the CI.

[maiermic]

@mhegazy Two tests failed on my machine. I ran gulp baseline-accept a second time and it modified two more files. I guess all tests will pass now, but this time I wait until my local test runner is done.

Update: Tests passed on my machine and I pushed my changes. Waiting on the CI again 😅

[bcherny]

@mhegazy Is it possible to merge this?

[mhegazy]

Sorry this fell off my list for a while. one more comment, we need to update the filter method on ReadOnlyArray, and the TypedArray varients, e.g. Int32Array (all in the same file).

[maiermic]

@mhegazy This pull request only updates filter on Array. I updated filter on ReadOnlyArray in #10027 (already merged). TypedArray varients cann't use a type guard. They are not generic and contain always the same type. No update possible. So it should be possible to merge this.

[ikokostya]

@mhegazy Could you review again taking into account latest comment #10916 (comment)?

[teppeis]

@maiermic @mhegazy any updates? I could resolve the conflicts and create new pr if you need.

[maiermic]

@teppeis Conflicts are resolved by my latest update. I'm waiting for @mhegazy to merge.

[NaridaL]

What's the status on this?

[mysticatea]

@mhegazy @maiermic What is happening with this?

[maiermic]

This has been solved by #16223 in the meantime.