-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement export as namespace from #34903
Conversation
dbc4677
to
33ae592
Compare
This only addresses half of #4813. The other half being |
up🙆🏻♂️ |
Could we get this down in 3.8?🤔 |
@Kingwl can ya sync it with |
@typescript-bot pack this |
I merged from master to fix conflicts, and I switched some of your tests to target multiple One thing I noticed was that you need a transform for |
@typescript-bot pack this again now that it's up to date |
export var a = 1; | ||
export var b = 2; | ||
//// [1.js] | ||
export * as ns from './0'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be transformed into something like
import * as _ns from './0';
export { _ns as ns };
I implemented |
@typescript-bot pack this |
Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at ed4f9b5. You can monitor the build here. It should now contribute to this PR's status checks. |
Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your
and then running |
Thank you!! |
Fixes (a part of) #4813