Rename BA2026.EnableAdditionalSdlSecurityChecks
#586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…crosoftCompilerSdlSwitch`.
marmegh
commented
Feb 25, 2022
| @@ -373,7 +373,7 @@ | |||
| "id": "NotApplicable_InvalidMetadata", | |||
| "arguments": [ | |||
| "Binskim.linux-x64.dll", | |||
| "EnableAdditionalSdlSecurityChecks", | |||
| "EnableMicrosoftCompilerSdlSwitch", | |||
There was a problem hiding this comment.
Many of these sarif file changes will become obsolete if #590 is completed first.
|
Please note, you will see a list of executables that have moved. This is due to the folder being renamed to match the new rule friendly name. In reply to: 1051058220 In reply to: 1051058220 In reply to: 1051058220 In reply to: 1051058220 |
Merged
| @@ -40,7 +40,7 @@ internal static class RuleIds | |||
|
|
|||
| public const string EnableSpectreMitigations = "BA2024"; | |||
| public const string EnableShadowStack = "BA2025"; | |||
| public const string EnableAdditionalSdlSecurityChecks = "BA2026"; | |||
| public const string EnableMicrosoftCompilerSdlSwitch = "BA2026"; | |||
… code comment from PR feedback.
eddynaka
reviewed
Mar 3, 2022
| { | ||
| /// <summary> | ||
| /// BA2026 | ||
| /// </summary> | ||
| public override string Id => RuleIds.EnableAdditionalSdlSecurityChecks; |
|
can u fix the conflicts, pls? In reply to: 1061382224 In reply to: 1061382224 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #584.
EnableAdditionalSdlSecurityChecksis unnecessarily vague. Renaming toEnableMicrosoftCompilerSdlSwitchto increase clarity for customers.