Updates the formating of the AdPat owner doc #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@negupt Could you change the name of this PR to something more declarative? The title becomes the commit message and we like them to be useful. Typically the best title answers the question: "If merged this PR will...". So the title could be something like:
|
| ``` | ||
|
|
||
| The following values are used like constants and should not need to change (unless the build pipeline definition is modified). | ||
|
|
There was a problem hiding this comment.
The cli commands are very helpful for those who don't want to use the UI and they've all been removed from this file. I vote to add those back. Can those be added back?
TechnicallyWilliams
changed the title
TechnicallyWilliams
changed the base branch from
negupt-bugFix
to
dexterw/features/update-install-docs
Removed last line.
TechnicallyWilliams
changed the base branch from
dexterw/features/update-install-docs
to
negupt-bugFix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
[YES] Have you followed the guidelines in our Contributing document?
[YES] Have you added an explanation of what your changes do and why you'd like us to include them?
[YES] I have updated the documentation accordingly.
[NA] I have added tests to cover my changes.
[NA] All new and existing tests passed.
[YES] My code follows the code style of this project.
[NA] I ran lint checks locally prior to submission.
[YES] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
What is the current behavior?
No open issue linked to this PR.
What is the new behavior?
Few steps were not clear. And, It provides better clarity in the documentation.
GETTING_STARTED_ADD_PAT_OWNER.md
Does this introduce a breaking change?
Any relevant logs, error output, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Other information