Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug-gym-llm-config-template entrypoint #101

Merged
merged 4 commits into from
Mar 27, 2025
Merged

Conversation

matheper
Copy link
Collaborator

No description provided.

@matheper matheper requested a review from Copilot March 27, 2025 12:57
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new entrypoint, "debug-gym-llm-config-template", to create an LLM config template for Debug Gym. The changes include new tests to validate various destination and override behaviors, the addition of the entrypoint in pyproject.toml, the implementation of the copy_llm_config_template function, and updated instructions in the README.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

File Description
tests/test_entrypoints.py Added tests for default, positional, named, and force override behaviors
pyproject.toml Registered the new script entrypoint for creating the LLM config template
debug_gym/entrypoints.py Implemented the copy_llm_config_template function to create/override the template
README.md Updated CLI usage instructions for the new entrypoint

@matheper matheper requested a review from Copilot March 27, 2025 17:14
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new entrypoint, debug-gym-init-llm-config, to create an LLM configuration template for users. Key changes include:

  • Adding tests for the new entrypoint in tests/test_entrypoints.py.
  • Registering the entrypoint in pyproject.toml.
  • Implementing the init_llm_config function in debug_gym/entrypoints.py to handle file creation and optional override.
  • Updating LLM configuration placeholders and error handling in debug_gym/agents/llm_api.py, plus README instructions.

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/test_entrypoints.py Tests added for default destination, positional and named destination, and override behavior.
pyproject.toml Registered the debug-gym-init-llm-config script entrypoint.
debug_gym/entrypoints.py Added init_llm_config function to copy the LLM config template and handle override logic.
debug_gym/agents/llm_api.py Updated LLM configuration template with new placeholders and enhanced error messaging.
README.md Updated instructions to reflect the new entrypoint usage.
Files not reviewed (1)
  • llm.template.yaml: Language not supported

@MarcCote MarcCote merged commit 1bd75cc into main Mar 27, 2025
6 checks passed
@MarcCote MarcCote deleted the template-script branch March 27, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants