Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds mssql-tools package to container #9

Closed
wants to merge 1 commit into from
Closed

feat: adds mssql-tools package to container #9

wants to merge 1 commit into from

Conversation

callbacknull
Copy link

resolves #8

@callbacknull
Copy link
Author

Thought I'd toss this in - I saw #8 and already had it laying around. :)

I signed the Azure CLA agreement too but do I need to actually sign a different one to contribute here?

@LuisBosquez
Copy link
Contributor

Hello @callbacknull! Unfortunately this repository doesn't map to the Dockerfile that gets used in the build process, so merging this PR wouldn't really translate to adding functionality.

We are already addressing this issue and it should be shipped soon. However, the resulting Dockerfile might differ. So I think it wouldn't really make sense to add this to the repository. I will close the PR for that reason.

This is due to the fact that SQL Server is not open-source, so the Dockerfile we shared is actually just for reference. I will bring up this item with the team on how we can better integrate the community with contributions to the actual publishable bits. I will keep you informed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tools are not installed in the container
2 participants