This repository was archived by the owner on Nov 1, 2023. It is now read-only.
Include LD_LIBRARY_PATH iff set by command
#1933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tevoinea
approved these changes
May 12, 2022
chkeita
approved these changes
May 12, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux, when calling
find_missing(), includeLD_LIBRARY_PATHif and only if the invokedCommandexplicitly sets some value for that variable. This ensures consistent search results, no matter the process environment of the calling context.Closes #1827.
dynamic-librarywith and withoutLD_LIBRARY_PATHset in env, set via flag{setup_dir}(passes no matter what, because we default toLD_LIBRARY_PATH={setup_dir}){setup_dir}/lib, notarget_env(fails){setup-dir}/lib, with--target_env LD_LIBRARY_PATH={setup_dir}/lib(passes)