Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[do not merge]: single-executable driver experiment #29557

Closed
wants to merge 1 commit into from

Conversation

mxschmitt
Copy link
Member

  • Experiment for [internal] Experiment with sea in the driver #29551.
  • No intention to get it merged as of of today, we'll wait until the feature reaches LTS.
  • Warm startup is around 10% faster.
  • Files / Directories decrease from 36 directories, 300 files to 1 single executable.
  • Java will especially benefit from this, since it extracts the driver for every execution. So 300 write operations per one Playwright.create().
  • This feature is supported on Windows/Linux/macOS
  • Was running the Playwright for Python sync tests and they were running seamless.

Notes for when we touch it again:

  • We need to generate the blob using the same Node.js version as we create the driver with

Copy link
Contributor

Test results for "tests 1"

4 flaky ⚠️ [chromium] › library/proxy.spec.ts:317:3 › should use SOCKS proxy for websocket requests
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/emulation-focus.spec.ts:65:3 › should not affect mouse event target page

26572 passed, 613 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant