Refactor: Fetch high contrast state via a cross platform hook #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why
This is part of a series of commits to reduce dependence on React Native Windows specific APIs, and allow the gallery to potentially run on macOS.
Currently,
App.tsxuses a React Native Windows specific JS API to fetch the high contrast state. This adds a direct import toreact-native-windowsthat isn't gated inside a platform check or file. This commit refactors the code to fetch high contrast state into a hook, so that the windows specific imports can be moved to afoo.windows.tsxfile, and so that we can also implement the macOS / mobile implementations separately.What
Moves high contrast fetching code to a new hook
useHighContrastState()Screenshots
No change should be seen to final app.
Microsoft Reviewers: Open in CodeFlow