[rush-azure-storage-plugin] Remove rush-sdk dependency from AzureStorageAuthentication #3971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the runtime dependency on @rushstack/rush-sdk from the AzureStorageAuthentication class
dmichon-msft
requested review from
iclanton,
octogonz and
apostolisms
as code owners
apostolisms
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the runtime dependency on @rushstack/rush-sdk from the AzureStorageAuthentication class so that it can be loaded in isolation.
Details
Moved the
credentialUpdateCommandForLoggingfield to be a constructor parameter instead of an abstract field, and stopped providing a default value inAzureStorageAuthentication, so that it no longer imports@rushstack/rush-sdk.How it was tested
Local build + unit test.
Impacted documentation
None.