Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use VT for COOKED_READ_DATA #17445

Merged
merged 24 commits into from
Jul 11, 2024
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
bbbe20f
Move colorbrewer into its own proper header
lhecker Jun 19, 2024
b0cc432
Use VT for COOKED_READ_DATA
lhecker Jun 19, 2024
e08ebbe
Fix GetVirtualViewport, Fix popup alignment
lhecker Jun 20, 2024
88ef5f4
Address feedback
lhecker Jun 20, 2024
413991e
Address feedback, Fix scrolling bug
lhecker Jun 21, 2024
8688a50
Merge remote-tracking branch 'origin/main' into dev/lhecker/14000-vt-…
lhecker Jun 21, 2024
32a1249
Fix several issues with control character visualizers
lhecker Jun 25, 2024
4471e98
Fix ambiguous chars, Improve F7+F9 UX
lhecker Jun 25, 2024
0e63bd0
Merge remote-tracking branch 'origin/main' into dev/lhecker/14000-vt-…
lhecker Jun 25, 2024
8f39b49
Overkill initialData impl, but hopefully not kill
lhecker Jun 25, 2024
b6e4046
Fix break not breaking, Fix column not columning
lhecker Jun 25, 2024
671f371
C++ cast
lhecker Jun 25, 2024
e5b8f5b
Fix cursor position after reflow
lhecker Jul 1, 2024
567260e
Fix prompt boundaries after wrapping
lhecker Jul 1, 2024
4cda975
Fix _viewport size after shrinking
lhecker Jul 1, 2024
398d795
More robust bodgy reflow hacks
lhecker Jul 2, 2024
2fe302c
Merge remote-tracking branch 'origin/main' into dev/lhecker/14000-vt-…
lhecker Jul 9, 2024
a63b806
Address feedback, Add comments, Update formatAttributes
lhecker Jul 9, 2024
8116d5b
Address j4james' feedback from the other PR
lhecker Jul 9, 2024
1f5dc90
Fix buffer invalidation
lhecker Jul 9, 2024
8c7cf58
Oh, right, we support graphemes
lhecker Jul 9, 2024
b3f11d5
Fix formatAttributes
lhecker Jul 9, 2024
08f3bac
Forgot to finish this
lhecker Jul 9, 2024
dc8ac1d
Improve comments, resize_and_overwrite is terrible
lhecker Jul 11, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix buffer invalidation
lhecker committed Jul 9, 2024
commit 1f5dc902c89af0a735866b718b7e09c8b4fa87ea
2 changes: 1 addition & 1 deletion src/host/readDataCooked.cpp
Original file line number Diff line number Diff line change
@@ -826,7 +826,7 @@ void COOKED_READ_DATA::_replace(size_t offset, size_t remove, const wchar_t* inp
if (offset <= _bufferDirtyBeg)
{
const auto& textBuffer = _screenInfo.GetTextBuffer();
_bufferDirtyBeg = textBuffer.GraphemePrev(_buffer, _bufferCursor);
_bufferDirtyBeg = textBuffer.GraphemePrev(_buffer, offset + 1);
}
}