Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Tab Menu Customization to Settings UI #18015

Merged
merged 24 commits into from
Dec 3, 2024
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
0e304d8
Add New Tab Menu Customization to Settings UI
carlos-zamora Mar 14, 2024
2cef0c1
[broken] drag and drop don't work
carlos-zamora Sep 20, 2024
cda72b6
Add nested folder support (and serialization)
carlos-zamora Oct 4, 2024
577ca8b
Add ability to modify current folder properties
carlos-zamora Oct 8, 2024
4d5616c
last bit of polish
carlos-zamora Oct 8, 2024
99d2d39
Add support for action entries
carlos-zamora Oct 8, 2024
a0a84f9
Display icons for actions and folders
carlos-zamora Oct 9, 2024
4b85165
accessibility pass
carlos-zamora Oct 9, 2024
78de36b
make NewTabMenuEntry::Copy virtual
carlos-zamora Oct 28, 2024
8fd6d9f
use std::vector; remove extra resources; remove redundant var
carlos-zamora Oct 28, 2024
0944064
Merge branch 'main' into dev/cazamor/SUI/newTabMenu
carlos-zamora Oct 28, 2024
4574b3d
Merge branch 'main' into dev/cazamor/SUI/newTabMenu
carlos-zamora Oct 30, 2024
babcd9f
thanks Leonard!
carlos-zamora Nov 6, 2024
b0c2558
Enable buttons iff items selected
carlos-zamora Nov 21, 2024
2bcf07e
Normalize size for item buttons
carlos-zamora Nov 21, 2024
e5ccac1
Make ListView larger (better for drag & drop)
carlos-zamora Nov 21, 2024
cdd8d32
Scroll to newly added entry
carlos-zamora Nov 21, 2024
53cfce7
Update SettingsNav's SelectedItem when discarding changes from a nest…
carlos-zamora Nov 21, 2024
06ef29c
Use EvaluatedIcon over Icon for profiles
carlos-zamora Nov 21, 2024
b1f695f
polish moving entries to folders
carlos-zamora Nov 21, 2024
1c661f7
address most of Pankaj's feedback
carlos-zamora Nov 22, 2024
aeab125
Navigate to correct folder when discarding changes
carlos-zamora Nov 22, 2024
3ca7810
QOL = Quality Of Life
carlos-zamora Nov 22, 2024
14f6c3e
subpage is a word!
carlos-zamora Nov 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Normalize size for item buttons
carlos-zamora committed Nov 21, 2024
commit 2bcf07e358fb904300f93254a8d2e1e09cf6f656
4 changes: 4 additions & 0 deletions src/cascadia/TerminalSettingsEditor/CommonResources.xaml
Original file line number Diff line number Diff line change
@@ -263,6 +263,8 @@
<Setter Property="Width" Value="25" />
<Setter Property="Padding" Value="0" />
<Setter Property="Margin" Value="0" />
<Setter Property="MinHeight" Value="0" />
<Setter Property="MinWidth" Value="0" />
</Style>

<Style x:Key="SmallButtonStyle"
@@ -305,6 +307,8 @@
<Setter Property="Width" Value="25" />
<Setter Property="Padding" Value="0" />
<Setter Property="Margin" Value="0" />
<Setter Property="MinHeight" Value="0" />
<Setter Property="MinWidth" Value="0" />
</Style>

<Style x:Key="IconButtonTextBlockStyle"