Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Assert class per group of feature #1238

Merged
merged 8 commits into from
Sep 12, 2022

Conversation

engyebrahim
Copy link
Member

No description provided.

@Evangelink Evangelink changed the title make assert class partial Split Assert class per group of feature Sep 9, 2022
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not add the new overloads in this PR.

Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last round of changes and we are good to go! Thanks @engyebrahim

@Evangelink Evangelink requested a review from Haplois September 12, 2022 11:23
@Evangelink Evangelink enabled auto-merge (squash) September 12, 2022 11:23
@Evangelink Evangelink disabled auto-merge September 12, 2022 11:29
@Evangelink Evangelink merged commit 786d75d into microsoft:main Sep 12, 2022
@engyebrahim engyebrahim deleted the pr/partial_assert_class branch September 12, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants