Update PlatformServices.Desktop.Component.Tests to use new test fwk #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
commented
Sep 14, 2022
Evangelink
commented
Sep 14, 2022
...entTests/TestAssets/TestProjectForAssemblyResolution/TestProjectForAssemblyResolution.csproj
Show resolved
Hide resolved
engyebrahim
previously approved these changes
Sep 14, 2022
test/ComponentTests/PlatformServices.Desktop.Component.Tests/DesktopTestSourceHostTests.cs
Show resolved
Hide resolved
test/ComponentTests/PlatformServices.Desktop.Component.Tests/DesktopTestSourceHostTests.cs
Outdated
Show resolved
Hide resolved
test/ComponentTests/PlatformServices.Desktop.Component.Tests/ReflectionUtilityTests.cs
Show resolved
Hide resolved
test/ComponentTests/TestAssets/SampleFrameworkExtensions/Properties/AssemblyInfo.cs
Show resolved
Hide resolved
Evangelink
force-pushed
the
convert-desktop-component
branch
2 times, most recently
from
631ab3c to
46050cc
Compare
These tests are referencing old versions of MSTest which is loaded in memory preventing the correct version (local) one to be loaded. This was ok up to now because we didn't do any big change (e.g. file rename).
Evangelink
force-pushed
the
convert-desktop-component
branch
from
46050cc to
b7b89a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also touches some other projects because these tests are referencing old versions of MSTest which is loaded in memory preventing the correct version (local) one to be loaded. This was ok up to now because we didn't do any big change (e.g. file rename).