Add tests to document test suite messages #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
force-pushed
the
Suite-Life-Cycle-Test
branch
from
be35187 to
684633e
Compare
Evangelink
reviewed
Oct 10, 2022
...LifeCycleTestProject/SuiteLifeCycleTestClass_ClassCleanupWithCleanupBehaviorEndOfAssembly.cs
Outdated
Show resolved
Hide resolved
...Project/SuiteLifeCycleTestClass_ClassCleanupWithInheritanceBehaviorBeforeEachDerivedClass.cs
Outdated
Show resolved
Hide resolved
...SuiteLifeCycleTestProject/SuiteLifeCycleTestClass_ClassCleanupWithInheritanceBehaviorNone.cs
Outdated
Show resolved
Hide resolved
...TestAssets/SuiteLifeCycleTestProject/SuiteLifeCycleTestClass_ClassCleanupWithoutAttribute.cs
Outdated
Show resolved
Hide resolved
Evangelink
force-pushed
the
Suite-Life-Cycle-Test
branch
from
d0eff2b to
6a4def4
Compare
Evangelink
requested changes
Oct 10, 2022
…m/testfx into Suite-Life-Cycle-Test # Conflicts: # test/E2ETests/Automation.CLI/CLITestBase.common.cs # test/E2ETests/Smoke.E2E.Tests/SuiteLifeCycleTests.cs
Evangelink
reviewed
Oct 11, 2022
...TestAssets/SuiteLifeCycleTestProject/SuiteLifeCycleTestClass_AssemblyInitializeAndCleanup.cs
Show resolved
Hide resolved
...feCycleTestProject/SuiteLifeCycleTestClass_InheretClassWithCleanupInheritanceBehaviorNone.cs
Outdated
Show resolved
Hide resolved
Evangelink
reviewed
Oct 13, 2022
There was a problem hiding this comment.
A few more remarks and we can merge this and start working on improving behaviors. Thank you so much for this awesome long work @engyebrahim. It helps us a lot in covering and understanding the behavior and how we can improve ux for users.
...TestAssets/SuiteLifeCycleTestProject/SuiteLifeCycleTestClass_AssemblyInitializeAndCleanup.cs
Outdated
Show resolved
Hide resolved
...TestAssets/SuiteLifeCycleTestProject/SuiteLifeCycleTestClass_AssemblyInitializeAndCleanup.cs
Show resolved
Hide resolved
# Conflicts: # TestFx.sln
Evangelink
previously approved these changes
Oct 13, 2022
Evangelink
approved these changes
Oct 13, 2022
Evangelink
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.