MSTEST0015: Test method should not be ignored

src/Analyzers/MSTest.Analyzers/AnalyzerReleases.Unshipped.md

@@ -12,3 +12,4 @@ MSTEST0011 | Usage | Warning | ClassCleanupShouldBeValidAnalyzer, [Documentation
 MSTEST0012 | Usage | Warning | AssemblyInitializeShouldBeValidAnalyzer, [Documentation](https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0012)
 MSTEST0013 | Usage | Warning | AssemblyCleanupShouldBeValidAnalyzer, [Documentation](https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0013)
 MSTEST0014 | Usage | Warning | DataRowShouldBeValidAnalyzer, [Documentation](https://learn.microsoft.com/dotnet/core/testing/unit-testing-mstest-analyzers-MSTEST0014)
+MSTEST0015 | Design | Info | TestMethodShouldNotBeIgnoredAnalyzer, [Documentation](https://learn.microsoft.com/dotnet/core/testing/unit-testing-mstest-analyzers-MSTEST0015)

src/Analyzers/MSTest.Analyzers/Helpers/DiagnosticIds.cs

@@ -19,4 +19,5 @@ internal static class DiagnosticIds
     public const string AssemblyInitializeShouldBeValidRuleId = "MSTEST0012";
     public const string AssemblyCleanupShouldBeValidRuleId = "MSTEST0013";
     public const string DataRowShouldBeValidRuleId = "MSTEST0014";
+    public const string TestMethodShouldNotBeIgnoredRuleId = "MSTEST0015";
 }

src/Analyzers/MSTest.Analyzers/Helpers/WellKnownTypeNames.cs

@@ -6,17 +6,18 @@ namespace MSTest.Analyzers;
 // IMPORTANT: Keep this file sorted alphabetically.
 internal static class WellKnownTypeNames
 {
+    public const string MicrosoftVisualStudioTestToolsUnitTestingAssemblyCleanupAttribute = "Microsoft.VisualStudio.TestTools.UnitTesting.AssemblyCleanupAttribute";
     public const string MicrosoftVisualStudioTestToolsUnitTestingAssemblyInitializeAttribute = "Microsoft.VisualStudio.TestTools.UnitTesting.AssemblyInitializeAttribute";
     public const string MicrosoftVisualStudioTestToolsUnitTestingClassCleanupAttribute = "Microsoft.VisualStudio.TestTools.UnitTesting.ClassCleanupAttribute";
     public const string MicrosoftVisualStudioTestToolsUnitTestingClassInitializeAttribute = "Microsoft.VisualStudio.TestTools.UnitTesting.ClassInitializeAttribute";
-    public const string MicrosoftVisualStudioTestToolsUnitTestingAssemblyCleanupAttribute = "Microsoft.VisualStudio.TestTools.UnitTesting.AssemblyCleanupAttribute";
     public const string MicrosoftVisualStudioTestToolsUnitTestingCssIterationAttribute = "Microsoft.VisualStudio.TestTools.UnitTesting.CssIterationAttribute";
     public const string MicrosoftVisualStudioTestToolsUnitTestingCssProjectStructureAttribute = "Microsoft.VisualStudio.TestTools.UnitTesting.CssProjectStructureAttribute";
     public const string MicrosoftVisualStudioTestToolsUnitTestingDataRowAttribute = "Microsoft.VisualStudio.TestTools.UnitTesting.DataRowAttribute";
     public const string MicrosoftVisualStudioTestToolsUnitTestingDescriptionAttribute = "Microsoft.VisualStudio.TestTools.UnitTesting.DescriptionAttribute";
     public const string MicrosoftVisualStudioTestToolsUnitTestingDiscoverInternalsAttribute = "Microsoft.VisualStudio.TestTools.UnitTesting.DiscoverInternalsAttribute";
     public const string MicrosoftVisualStudioTestToolsUnitTestingDoNotParallelizeAttribute = "Microsoft.VisualStudio.TestTools.UnitTesting.DoNotParallelizeAttribute";
     public const string MicrosoftVisualStudioTestToolsUnitTestingExpectedExceptionAttribute = "Microsoft.VisualStudio.TestTools.UnitTesting.ExpectedExceptionAttribute";
+    public const string MicrosoftVisualStudioTestToolsUnitTestingIgnoreAttribute = "Microsoft.VisualStudio.TestTools.UnitTesting.IgnoreAttribute";
     public const string MicrosoftVisualStudioTestToolsUnitTestingOwnerAttribute = "Microsoft.VisualStudio.TestTools.UnitTesting.OwnerAttribute";
     public const string MicrosoftVisualStudioTestToolsUnitTestingParallelizeAttribute = "Microsoft.VisualStudio.TestTools.UnitTesting.ParallelizeAttribute";
     public const string MicrosoftVisualStudioTestToolsUnitTestingPriorityAttribute = "Microsoft.VisualStudio.TestTools.UnitTesting.PriorityAttribute";

src/Analyzers/MSTest.Analyzers/Resources.resx

@@ -445,6 +445,15 @@
   <data name="TestMethodShouldBeValidTitle" xml:space="preserve">
     <value>Test methods should have valid layout</value>
   </data>
+  <data name="TestMethodShouldNotBeIgnoredAnalyzerDescription" xml:space="preserve">
+    <value>Test methods should not be ignored (marked with '[Ignore]').</value>
+  </data>
+  <data name="TestMethodShouldNotBeIgnoredAnalyzerFormat" xml:space="preserve">
+    <value>Test method '{0}' should not be ignored</value>
+  </data>
+  <data name="TestMethodShouldNotBeIgnoredAnalyzerTitle" xml:space="preserve">
+    <value>Test method should not be ignored</value>
+  </data>
   <data name="UseAttributeOnTestMethodAnalyzerMessageFormat" xml:space="preserve">
     <value>[{0}] can only be set on methods marked with [TestMethod]</value>
   </data>

src/Analyzers/MSTest.Analyzers/TestMethodShouldNotBeIgnoredAnalyzer.cs

@@ -0,0 +1,72 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+using System.Collections.Immutable;
+
+using Analyzer.Utilities.Extensions;
+
+using Microsoft.CodeAnalysis;
+using Microsoft.CodeAnalysis.Diagnostics;
+
+using MSTest.Analyzers.Helpers;
+
+namespace MSTest.Analyzers;
+
+[DiagnosticAnalyzer(LanguageNames.CSharp, LanguageNames.VisualBasic)]
+public sealed class TestMethodShouldNotBeIgnoredAnalyzer : DiagnosticAnalyzer
+{
+    private static readonly LocalizableResourceString Title = new(nameof(Resources.TestMethodShouldNotBeIgnoredAnalyzerTitle), Resources.ResourceManager, typeof(Resources));
+    private static readonly LocalizableResourceString Description = new(nameof(Resources.TestMethodShouldNotBeIgnoredAnalyzerDescription), Resources.ResourceManager, typeof(Resources));
+    private static readonly LocalizableResourceString MessageFormat = new(nameof(Resources.TestMethodShouldNotBeIgnoredAnalyzerFormat), Resources.ResourceManager, typeof(Resources));
+
+    internal static readonly DiagnosticDescriptor TestMethodShouldNotBeIgnoredRule = DiagnosticDescriptorHelper.Create(
+        DiagnosticIds.TestMethodShouldNotBeIgnoredRuleId,
+        Title,
+        MessageFormat,
+        Description,
+        Category.Design,
+        DiagnosticSeverity.Info,
+        isEnabledByDefault: true);
+
+    public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get; }
+        = ImmutableArray.Create(TestMethodShouldNotBeIgnoredRule);
+
+    public override void Initialize(AnalysisContext context)
+    {
+        context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None);
+        context.EnableConcurrentExecution();
+        context.RegisterCompilationStartAction(context =>
+        {
+            if (context.Compilation.TryGetOrCreateTypeByMetadataName(WellKnownTypeNames.MicrosoftVisualStudioTestToolsUnitTestingIgnoreAttribute, out var ignoreAttributeSymbol)
+                && context.Compilation.TryGetOrCreateTypeByMetadataName(WellKnownTypeNames.MicrosoftVisualStudioTestToolsUnitTestingTestMethodAttribute, out var testMethodAttributeSymbol))
+            {
+                context.RegisterSymbolAction(
+                    context => AnalyzeSymbol(context, ignoreAttributeSymbol, testMethodAttributeSymbol),
+                    SymbolKind.Method);
+            }
+        });
+    }
+
+    private static void AnalyzeSymbol(SymbolAnalysisContext context, INamedTypeSymbol ignoreAttributeSymbol, INamedTypeSymbol testMethodAttributeSymbol)
+    {
+        var methodSymbol = (IMethodSymbol)context.Symbol;
+        var methodAttributes = methodSymbol.GetAttributes();
+        bool isTestMethod = false;
+        List<AttributeData> dataRowAttributes = new();
+        foreach (var methodAttribute in methodAttributes)
+        {
+            // Current method should be a test method or should inherit from the TestMethod attribute.
+            if (methodAttribute.AttributeClass.Inherits(testMethodAttributeSymbol))
+            {
+                isTestMethod = true;
+            }
+        }
+
+        if (!isTestMethod || !methodAttributes.Any(attr => SymbolEqualityComparer.Default.Equals(attr.AttributeClass, ignoreAttributeSymbol)))
+        {
+            return;
+        }
+
+        context.ReportDiagnostic(methodSymbol.CreateDiagnostic(TestMethodShouldNotBeIgnoredRule, methodSymbol.Name));
+    }
+}

src/Analyzers/MSTest.Analyzers/xlf/Resources.cs.xlf

@@ -575,6 +575,21 @@
         <target state="translated">Testovací metody by měly mít platné rozložení.</target>
         <note />
       </trans-unit>
+      <trans-unit id="TestMethodShouldNotBeIgnoredAnalyzerDescription">
+        <source>Test methods should not be ignored (marked with '[Ignore]').</source>
+        <target state="new">Test methods should not be ignored (marked with '[Ignore]').</target>
+        <note />
+      </trans-unit>
+      <trans-unit id="TestMethodShouldNotBeIgnoredAnalyzerFormat">
+        <source>Test method '{0}' should not be ignored</source>
+        <target state="new">Test method '{0}' should not be ignored</target>
+        <note />
+      </trans-unit>
+      <trans-unit id="TestMethodShouldNotBeIgnoredAnalyzerTitle">
+        <source>Test method should not be ignored</source>
+        <target state="new">Test method should not be ignored</target>
+        <note />
+      </trans-unit>
       <trans-unit id="UseAttributeOnTestMethodAnalyzerMessageFormat">
         <source>[{0}] can only be set on methods marked with [TestMethod]</source>
         <target state="translated">[{0}] lze nastavit pouze u metod označených pomocí metody [TestMethod].</target>

src/Analyzers/MSTest.Analyzers/xlf/Resources.de.xlf

@@ -569,6 +569,21 @@
         <target state="translated">Testmethoden müssen über ein gültiges Layout verfügen.</target>
         <note />
       </trans-unit>
+      <trans-unit id="TestMethodShouldNotBeIgnoredAnalyzerDescription">
+        <source>Test methods should not be ignored (marked with '[Ignore]').</source>
+        <target state="new">Test methods should not be ignored (marked with '[Ignore]').</target>
+        <note />
+      </trans-unit>
+      <trans-unit id="TestMethodShouldNotBeIgnoredAnalyzerFormat">
+        <source>Test method '{0}' should not be ignored</source>
+        <target state="new">Test method '{0}' should not be ignored</target>
+        <note />
+      </trans-unit>
+      <trans-unit id="TestMethodShouldNotBeIgnoredAnalyzerTitle">
+        <source>Test method should not be ignored</source>
+        <target state="new">Test method should not be ignored</target>
+        <note />
+      </trans-unit>
       <trans-unit id="UseAttributeOnTestMethodAnalyzerMessageFormat">
         <source>[{0}] can only be set on methods marked with [TestMethod]</source>
         <target state="translated">[{0}] kann nur für Methoden festgelegt werden, die mit [TestMethod] markiert sind.</target>

src/Analyzers/MSTest.Analyzers/xlf/Resources.es.xlf

@@ -569,6 +569,21 @@
         <target state="translated">Los métodos de prueba deben tener un diseño válido</target>
         <note />
       </trans-unit>
+      <trans-unit id="TestMethodShouldNotBeIgnoredAnalyzerDescription">
+        <source>Test methods should not be ignored (marked with '[Ignore]').</source>
+        <target state="new">Test methods should not be ignored (marked with '[Ignore]').</target>
+        <note />
+      </trans-unit>
+      <trans-unit id="TestMethodShouldNotBeIgnoredAnalyzerFormat">
+        <source>Test method '{0}' should not be ignored</source>
+        <target state="new">Test method '{0}' should not be ignored</target>
+        <note />
+      </trans-unit>
+      <trans-unit id="TestMethodShouldNotBeIgnoredAnalyzerTitle">
+        <source>Test method should not be ignored</source>
+        <target state="new">Test method should not be ignored</target>
+        <note />
+      </trans-unit>
       <trans-unit id="UseAttributeOnTestMethodAnalyzerMessageFormat">
         <source>[{0}] can only be set on methods marked with [TestMethod]</source>
         <target state="translated">[{0}] solo se puede establecer en métodos marcados con [TestMethod]</target>

src/Analyzers/MSTest.Analyzers/xlf/Resources.fr.xlf

@@ -569,6 +569,21 @@
         <target state="translated">Les méthodes de test doivent avoir une disposition valide</target>
         <note />
       </trans-unit>
+      <trans-unit id="TestMethodShouldNotBeIgnoredAnalyzerDescription">
+        <source>Test methods should not be ignored (marked with '[Ignore]').</source>
+        <target state="new">Test methods should not be ignored (marked with '[Ignore]').</target>
+        <note />
+      </trans-unit>
+      <trans-unit id="TestMethodShouldNotBeIgnoredAnalyzerFormat">
+        <source>Test method '{0}' should not be ignored</source>
+        <target state="new">Test method '{0}' should not be ignored</target>
+        <note />
+      </trans-unit>
+      <trans-unit id="TestMethodShouldNotBeIgnoredAnalyzerTitle">
+        <source>Test method should not be ignored</source>
+        <target state="new">Test method should not be ignored</target>
+        <note />
+      </trans-unit>
       <trans-unit id="UseAttributeOnTestMethodAnalyzerMessageFormat">
         <source>[{0}] can only be set on methods marked with [TestMethod]</source>
         <target state="translated">[{0}] ne peut être défini que sur les méthodes marquées avec [TestMethod]</target>

src/Analyzers/MSTest.Analyzers/xlf/Resources.it.xlf

@@ -569,6 +569,21 @@
         <target state="translated">I metodi di test dovrebbero avere un layout valido</target>
         <note />
       </trans-unit>
+      <trans-unit id="TestMethodShouldNotBeIgnoredAnalyzerDescription">
+        <source>Test methods should not be ignored (marked with '[Ignore]').</source>
+        <target state="new">Test methods should not be ignored (marked with '[Ignore]').</target>
+        <note />
+      </trans-unit>
+      <trans-unit id="TestMethodShouldNotBeIgnoredAnalyzerFormat">
+        <source>Test method '{0}' should not be ignored</source>
+        <target state="new">Test method '{0}' should not be ignored</target>
+        <note />
+      </trans-unit>
+      <trans-unit id="TestMethodShouldNotBeIgnoredAnalyzerTitle">
+        <source>Test method should not be ignored</source>
+        <target state="new">Test method should not be ignored</target>
+        <note />
+      </trans-unit>
       <trans-unit id="UseAttributeOnTestMethodAnalyzerMessageFormat">
         <source>[{0}] can only be set on methods marked with [TestMethod]</source>
         <target state="translated">[{0}] può essere impostato solo su metodi contrassegnati con [TestMethod]</target>

src/Analyzers/MSTest.Analyzers/xlf/Resources.ja.xlf

@@ -570,6 +570,21 @@
         <target state="translated">テスト メソッドには有効なレイアウトが必要です</target>
         <note />
       </trans-unit>
+      <trans-unit id="TestMethodShouldNotBeIgnoredAnalyzerDescription">
+        <source>Test methods should not be ignored (marked with '[Ignore]').</source>
+        <target state="new">Test methods should not be ignored (marked with '[Ignore]').</target>
+        <note />
+      </trans-unit>
+      <trans-unit id="TestMethodShouldNotBeIgnoredAnalyzerFormat">
+        <source>Test method '{0}' should not be ignored</source>
+        <target state="new">Test method '{0}' should not be ignored</target>
+        <note />
+      </trans-unit>
+      <trans-unit id="TestMethodShouldNotBeIgnoredAnalyzerTitle">
+        <source>Test method should not be ignored</source>
+        <target state="new">Test method should not be ignored</target>
+        <note />
+      </trans-unit>
       <trans-unit id="UseAttributeOnTestMethodAnalyzerMessageFormat">
         <source>[{0}] can only be set on methods marked with [TestMethod]</source>
         <target state="translated">[{0}] は、[TestMethod] でマークされたメソッドにのみ設定できます</target>

src/Analyzers/MSTest.Analyzers/xlf/Resources.ko.xlf

@@ -570,6 +570,21 @@
         <target state="translated">테스트 메서드에는 유효한 레이아웃이 있어야 합니다.</target>
         <note />
       </trans-unit>
+      <trans-unit id="TestMethodShouldNotBeIgnoredAnalyzerDescription">
+        <source>Test methods should not be ignored (marked with '[Ignore]').</source>
+        <target state="new">Test methods should not be ignored (marked with '[Ignore]').</target>
+        <note />
+      </trans-unit>
+      <trans-unit id="TestMethodShouldNotBeIgnoredAnalyzerFormat">
+        <source>Test method '{0}' should not be ignored</source>
+        <target state="new">Test method '{0}' should not be ignored</target>
+        <note />
+      </trans-unit>
+      <trans-unit id="TestMethodShouldNotBeIgnoredAnalyzerTitle">
+        <source>Test method should not be ignored</source>
+        <target state="new">Test method should not be ignored</target>
+        <note />
+      </trans-unit>
       <trans-unit id="UseAttributeOnTestMethodAnalyzerMessageFormat">
         <source>[{0}] can only be set on methods marked with [TestMethod]</source>
         <target state="translated">[{0}]은(는) [TestMethod] 표시된 메서드에만 설정할 수 있습니다.</target>

src/Analyzers/MSTest.Analyzers/xlf/Resources.pl.xlf

@@ -569,6 +569,21 @@
         <target state="translated">Metody testowe powinny mieć prawidłowy układ</target>
         <note />
       </trans-unit>
+      <trans-unit id="TestMethodShouldNotBeIgnoredAnalyzerDescription">
+        <source>Test methods should not be ignored (marked with '[Ignore]').</source>
+        <target state="new">Test methods should not be ignored (marked with '[Ignore]').</target>
+        <note />
+      </trans-unit>
+      <trans-unit id="TestMethodShouldNotBeIgnoredAnalyzerFormat">
+        <source>Test method '{0}' should not be ignored</source>
+        <target state="new">Test method '{0}' should not be ignored</target>
+        <note />
+      </trans-unit>
+      <trans-unit id="TestMethodShouldNotBeIgnoredAnalyzerTitle">
+        <source>Test method should not be ignored</source>
+        <target state="new">Test method should not be ignored</target>
+        <note />
+      </trans-unit>
       <trans-unit id="UseAttributeOnTestMethodAnalyzerMessageFormat">
         <source>[{0}] can only be set on methods marked with [TestMethod]</source>
         <target state="translated">[{0}] można ustawić tylko dla metod oznaczonych znakiem [TestMethod]</target>