Add PreferAssertFailOverAlwaysFalseConditionsAnalyzer #2799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
force-pushed
the
always-false-analyzer
branch
from
01a4f2b to
2fec7c0
Compare
Youssef1313
force-pushed
the
always-false-analyzer
branch
from
2fec7c0 to
7744f15
Compare
Evangelink
reviewed
May 3, 2024
There was a problem hiding this comment.
Nice to see you here @Youssef1313! I added a few comments/nits
src/Analyzers/MSTest.Analyzers/PreferAssertFailOverAlwaysFalseConditionsAnalyzer.cs
Outdated
Show resolved
Hide resolved
...itTests/MSTest.Analyzers.UnitTests/PreferAssertFailOverAlwaysFalseConditionsAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
...itTests/MSTest.Analyzers.UnitTests/PreferAssertFailOverAlwaysFalseConditionsAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
...itTests/MSTest.Analyzers.UnitTests/PreferAssertFailOverAlwaysFalseConditionsAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Amaury Levé <[email protected]>
Co-authored-by: Amaury Levé <[email protected]>
Thank you! and thanks for the review! I addressed the review comments and updated testsbaseline.txt. Let's see if CI will be green now. |
Evangelink
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2753