Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve display name for DynamicDataAttribute #3293

Merged
merged 6 commits into from
Jul 22, 2024

Conversation

Evangelink
Copy link
Member

@Evangelink Evangelink commented Jul 22, 2024

Copies logic from @MichelZ for DataRowAttribute for DynamicDataAttribute. This is improving the display for string, char, null and collections.

Before:
image

After:
image

nohwnd
nohwnd previously approved these changes Jul 22, 2024
fhnaseer
fhnaseer previously approved these changes Jul 22, 2024
# Conflicts:
#	test/IntegrationTests/MSTest.IntegrationTests/Parameterized tests/DynamicDataTests.cs
#	test/IntegrationTests/MSTest.VstestConsoleWrapper.IntegrationTests/Parameterized tests/DynamicDataTests.cs
@Evangelink Evangelink dismissed stale reviews from fhnaseer and nohwnd via efc8bd9 July 22, 2024 12:34
@Evangelink Evangelink merged commit 81447f5 into microsoft:main Jul 22, 2024
6 checks passed
@Evangelink Evangelink deleted the display-name-dynamic-data branch July 22, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants