Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add support for overloaded parameterized tests #3298

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Feat: add support for overloaded parameterized tests #3298

merged 2 commits into from
Jul 22, 2024

Conversation

Evangelink
Copy link
Member

Fixes #1253

nohwnd
nohwnd reviewed Jul 22, 2024
View reviewed changes
Copy link
Member

@nohwnd nohwnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see other mentions of the same code in TypeEnumerator, where we will take just the method name, but not the signature. Should that stay as is?

image

@Evangelink
Copy link
Member Author

I haven't reviewed all code, I have only ensured the overloads are handled correctly for DataRow and DynamicData. For the screenshot you have, this is the default display name for a method if no display name is provided so I think it's fine (at least for the context of this PR).

@Evangelink Evangelink merged commit f380939 into microsoft:main Jul 22, 2024
6 checks passed
@Evangelink Evangelink deleted the overload branch July 22, 2024 12:22
@Evangelink Evangelink mentioned this pull request Oct 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nohwnd nohwnd nohwnd approved these changes

Assignees
No one assigned
Labels
Area: Parameterized tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data-driven tests are not fully supported for overloaded test methods
2 participants
@Evangelink @nohwnd