MSTEST0010: report when class is abstract and inheritance is not set

src/Analyzers/MSTest.Analyzers/ClassInitializeShouldBeValidAnalyzer.cs

@@ -58,11 +58,12 @@ private static void AnalyzeSymbol(SymbolAnalysisContext context, INamedTypeSymbo
         bool canDiscoverInternals)
     {
         var methodSymbol = (IMethodSymbol)context.Symbol;
-
+        bool isInheritanceModeSet = methodSymbol.IsInheritanceModeSet(inheritanceBehaviorSymbol, classInitializeAttributeSymbol);
         if (methodSymbol.IsClassInitializeMethod(classInitializeAttributeSymbol)
-            && !methodSymbol.HasValidFixtureMethodSignature(taskSymbol, valueTaskSymbol, canDiscoverInternals, shouldBeStatic: true,
-                allowGenericType: methodSymbol.IsInheritanceModeSet(inheritanceBehaviorSymbol, classInitializeAttributeSymbol), testContextSymbol,
+            && ((!methodSymbol.HasValidFixtureMethodSignature(taskSymbol, valueTaskSymbol, canDiscoverInternals, shouldBeStatic: true,
+                allowGenericType: isInheritanceModeSet, testContextSymbol,
                 testClassAttributeSymbol, fixtureAllowInheritedTestClass: true, out bool isFixable))
+                || (!isInheritanceModeSet && methodSymbol.ContainingType.IsAbstract)))
         {
             context.ReportDiagnostic(isFixable
                 ? methodSymbol.CreateDiagnostic(Rule, methodSymbol.Name)

src/Analyzers/MSTest.Analyzers/Resources.resx

@@ -197,7 +197,8 @@
 - take a single parameter of type 'TestContext'
 - return type should be 'void', 'Task' or 'ValueTask'
 - not be 'async void'
-- not be a special method (finalizer, operator...).</value>
+- not be a special method (finalizer, operator...)
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'.</value>
   </data>
   <data name="ClassInitializeShouldBeValidMessageFormat" xml:space="preserve">
     <value>ClassInitialize method '{0}' signature is invalid</value>

src/Analyzers/MSTest.Analyzers/xlf/Resources.cs.xlf

@@ -139,8 +139,9 @@
 - take a single parameter of type 'TestContext'
 - return type should be 'void', 'Task' or 'ValueTask'
 - not be 'async void'
-- not be a special method (finalizer, operator...).</source>
-        <target state="translated">Aby byly metody s označením [ClassInitialize] platné, musí se řídit následujícím rozložením: 
+- not be a special method (finalizer, operator...)
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'.</source>
+        <target state="needs-review-translation">Aby byly metody s označením [ClassInitialize] platné, musí se řídit následujícím rozložením: 
 – být „public“
 – být „static“
 – nesmí být obecné ani definované pro obecnou třídu

src/Analyzers/MSTest.Analyzers/xlf/Resources.de.xlf

@@ -137,8 +137,9 @@
 - take a single parameter of type 'TestContext'
 - return type should be 'void', 'Task' or 'ValueTask'
 - not be 'async void'
-- not be a special method (finalizer, operator...).</source>
-        <target state="translated">Methoden, die mit [ClassInitialize] gekennzeichnet sind, müssen dem folgenden Layout folgen, um gültig zu sein:
+- not be a special method (finalizer, operator...)
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'.</source>
+        <target state="needs-review-translation">Methoden, die mit [ClassInitialize] gekennzeichnet sind, müssen dem folgenden Layout folgen, um gültig zu sein:
 – "öffentlich" sein 
 – "statisch" sein
 – nicht generisch oder für eine generische Klasse definiert sein

src/Analyzers/MSTest.Analyzers/xlf/Resources.es.xlf

@@ -137,8 +137,9 @@
 - take a single parameter of type 'TestContext'
 - return type should be 'void', 'Task' or 'ValueTask'
 - not be 'async void'
-- not be a special method (finalizer, operator...).</source>
-        <target state="translated">Los métodos marcados con [ClassInitialize] deberían seguir el siguiente diseño para ser válidos:
+- not be a special method (finalizer, operator...)
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'.</source>
+        <target state="needs-review-translation">Los métodos marcados con [ClassInitialize] deberían seguir el siguiente diseño para ser válidos:
 - ser "public" 
 - ser "static"
 - no ser genérico ni estar definido en una clase genérica

src/Analyzers/MSTest.Analyzers/xlf/Resources.fr.xlf

@@ -137,8 +137,9 @@
 - take a single parameter of type 'TestContext'
 - return type should be 'void', 'Task' or 'ValueTask'
 - not be 'async void'
-- not be a special method (finalizer, operator...).</source>
-        <target state="translated">Les méthodes marquées par [ClassInitialize] doivent respecter le schéma suivant pour être valides : 
+- not be a special method (finalizer, operator...)
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'.</source>
+        <target state="needs-review-translation">Les méthodes marquées par [ClassInitialize] doivent respecter le schéma suivant pour être valides : 
 - être « public » 
 - être "statique"
 - ne pas être générique ni être défini sur une classe générique

src/Analyzers/MSTest.Analyzers/xlf/Resources.it.xlf

@@ -137,8 +137,9 @@
 - take a single parameter of type 'TestContext'
 - return type should be 'void', 'Task' or 'ValueTask'
 - not be 'async void'
-- not be a special method (finalizer, operator...).</source>
-        <target state="translated">I metodi contrassegnati con [ClassInitialize] devono seguire il layout seguente per essere validi:
+- not be a special method (finalizer, operator...)
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'.</source>
+        <target state="needs-review-translation">I metodi contrassegnati con [ClassInitialize] devono seguire il layout seguente per essere validi:
 - devono essere 'public' 
 - devono essere 'static'
 - non devono essere generici né essere definiti in una classe generica

src/Analyzers/MSTest.Analyzers/xlf/Resources.ja.xlf

@@ -137,8 +137,9 @@
 - take a single parameter of type 'TestContext'
 - return type should be 'void', 'Task' or 'ValueTask'
 - not be 'async void'
-- not be a special method (finalizer, operator...).</source>
-        <target state="translated">[ClassInitialize] でマークされたメソッドを有効にするには、次のレイアウトに従う必要があります:
+- not be a special method (finalizer, operator...)
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'.</source>
+        <target state="needs-review-translation">[ClassInitialize] でマークされたメソッドを有効にするには、次のレイアウトに従う必要があります:
 - 'public' である 
 - 'static' である
 - ジェネリックではなく、ジェネリック クラスでも定義されていない

src/Analyzers/MSTest.Analyzers/xlf/Resources.ko.xlf

@@ -137,8 +137,9 @@
 - take a single parameter of type 'TestContext'
 - return type should be 'void', 'Task' or 'ValueTask'
 - not be 'async void'
-- not be a special method (finalizer, operator...).</source>
-        <target state="translated">[ClassInitialize]로 표시된 메서드가 유효하려면 다음 레이아웃을 따라야 합니다.
+- not be a special method (finalizer, operator...)
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'.</source>
+        <target state="needs-review-translation">[ClassInitialize]로 표시된 메서드가 유효하려면 다음 레이아웃을 따라야 합니다.
 - 'public'이어야 합니다.
 - 'static'이어야 합니다.
 - 제네릭이 아니거나 제네릭 클래스에 정의되지 않음

src/Analyzers/MSTest.Analyzers/xlf/Resources.pl.xlf

@@ -137,8 +137,9 @@
 - take a single parameter of type 'TestContext'
 - return type should be 'void', 'Task' or 'ValueTask'
 - not be 'async void'
-- not be a special method (finalizer, operator...).</source>
-        <target state="translated">Metody oznaczone za pomocą [ClassInitialize] powinny być zgodne z następującym układem, aby były prawidłowe:
+- not be a special method (finalizer, operator...)
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'.</source>
+        <target state="needs-review-translation">Metody oznaczone za pomocą [ClassInitialize] powinny być zgodne z następującym układem, aby były prawidłowe:
 — być „publiczne” 
 — być "statyczne"
 - nie być ogólne ani być zdefiniowane w klasie ogólnej

src/Analyzers/MSTest.Analyzers/xlf/Resources.pt-BR.xlf

@@ -137,8 +137,9 @@
 - take a single parameter of type 'TestContext'
 - return type should be 'void', 'Task' or 'ValueTask'
 - not be 'async void'
-- not be a special method (finalizer, operator...).</source>
-        <target state="translated">Os métodos marcados com [ClassInitialize] devem seguir o seguinte layout para serem válidos:
+- not be a special method (finalizer, operator...)
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'.</source>
+        <target state="needs-review-translation">Os métodos marcados com [ClassInitialize] devem seguir o seguinte layout para serem válidos:
 — ser "público" 
 — ser "estático"
 — não ser genérico nem ser definido em uma classe genérica

src/Analyzers/MSTest.Analyzers/xlf/Resources.ru.xlf

@@ -137,8 +137,9 @@
 - take a single parameter of type 'TestContext'
 - return type should be 'void', 'Task' or 'ValueTask'
 - not be 'async void'
-- not be a special method (finalizer, operator...).</source>
-        <target state="translated">Чтобы методы, отмеченные [ClassInitialize], были допустимыми, они должны соответствовать следующему макету:
+- not be a special method (finalizer, operator...)
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'.</source>
+        <target state="needs-review-translation">Чтобы методы, отмеченные [ClassInitialize], были допустимыми, они должны соответствовать следующему макету:
 – должны быть "общедоступными" 
 – должны быть "статическими"
 – не должны быть универсальным и не должны определяться в универсальном классе

src/Analyzers/MSTest.Analyzers/xlf/Resources.tr.xlf

@@ -137,8 +137,9 @@
 - take a single parameter of type 'TestContext'
 - return type should be 'void', 'Task' or 'ValueTask'
 - not be 'async void'
-- not be a special method (finalizer, operator...).</source>
-        <target state="translated">[ClassInitialize] ile işaretlenen yöntemlerin geçerli olması için aşağıdaki düzeni takip etmesi gerekir:
+- not be a special method (finalizer, operator...)
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'.</source>
+        <target state="needs-review-translation">[ClassInitialize] ile işaretlenen yöntemlerin geçerli olması için aşağıdaki düzeni takip etmesi gerekir:
 - 'public' olmalı
 - 'static' olmalı
 - genel olamaz veya genel bir sınıf üzerinde tanımlanamaz

src/Analyzers/MSTest.Analyzers/xlf/Resources.zh-Hans.xlf

@@ -137,8 +137,9 @@
 - take a single parameter of type 'TestContext'
 - return type should be 'void', 'Task' or 'ValueTask'
 - not be 'async void'
-- not be a special method (finalizer, operator...).</source>
-        <target state="translated">标记有 [ClassInitialize] 的方法应遵循以下布局才会有效:
+- not be a special method (finalizer, operator...)
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'.</source>
+        <target state="needs-review-translation">标记有 [ClassInitialize] 的方法应遵循以下布局才会有效:
 - 是 “public” 
 - 是 “static”
 - 不是泛型的，也不是在泛型类上定义的

src/Analyzers/MSTest.Analyzers/xlf/Resources.zh-Hant.xlf

@@ -137,8 +137,9 @@
 - take a single parameter of type 'TestContext'
 - return type should be 'void', 'Task' or 'ValueTask'
 - not be 'async void'
-- not be a special method (finalizer, operator...).</source>
-        <target state="translated">標示為 [ClassInitialize] 的方法應該遵循下列配置才能有效:
+- not be a special method (finalizer, operator...)
+-'InheritanceBehavior.BeforeEachDerivedClass' attribute parameter should be specified if the class is 'abstract'.</source>
+        <target state="needs-review-translation">標示為 [ClassInitialize] 的方法應該遵循下列配置才能有效:
 - 為 'public' 
 - 為 'static'
 - 非為泛型也不是在泛型類別上所定義

test/UnitTests/MSTest.Analyzers.UnitTests/ClassInitializeShouldBeValidAnalyzerTests.cs

@@ -541,4 +541,92 @@ public static void ClassInitialize(TestContext testContext)
 
         await VerifyCS.VerifyAnalyzerAsync(code);
     }
+
+    public async Task WhenClassInitializeIsOnAbstractClassNotMarkedWithTestClass_AndWithInheritanceBehavior_NoDiagnostic()
+    {
+        string code = """
+            using Microsoft.VisualStudio.TestTools.UnitTesting;
+
+            public abstract class MyTestClass
+            {
+                [ClassInitialize(InheritanceBehavior.BeforeEachDerivedClass)]
+                public static void ClassInitialize(TestContext testContext)
+                {
+                }
+            }
+            """;
+
+        await VerifyCS.VerifyAnalyzerAsync(code);
+    }
+
+    public async Task WhenClassInitializeIsOnAbstractClassMarkedWithTestClass_AndWithInheritanceBehavior_NoDiagnostic()
+    {
+        string code = """
+            using Microsoft.VisualStudio.TestTools.UnitTesting;
+
+            [TestClass]
+            public abstract class MyTestClass
+            {
+                [ClassInitialize(InheritanceBehavior.BeforeEachDerivedClass)]
+                public static void ClassInitialize(TestContext testContext)
+                {
+                }
+            }
+            """;
+
+        await VerifyCS.VerifyAnalyzerAsync(code);
+    }
+
+    public async Task WhenClassInitializeIsAbstractClassNotMarkedWithTestClass_AndWithoutInheritanceBehavior_Diagnostic()
+    {
+        string code = """
+            using Microsoft.VisualStudio.TestTools.UnitTesting;
+
+            public abstract class MyTestClass
+            {
+                [ClassInitialize]
+                public static void [|ClassInitialize|](TestContext testContext)
+                {
+                }
+            }
+            """;
+
+        await VerifyCS.VerifyAnalyzerAsync(code);
+    }
+
+    public async Task WhenClassInitializeIsOnAbstractClassMarkedWithTestClass_AndWithoutInheritanceBehavior_Diagnostic()
+    {
+        string code = """
+            using Microsoft.VisualStudio.TestTools.UnitTesting;
+
+            [TestClass]
+            public abstract class MyTestClass
+            {
+                [ClassInitialize]
+                public static void [|ClassInitialize|](TestContext testContext)
+                {
+                }
+            }
+            """;
+
+        await VerifyCS.VerifyAnalyzerAsync(code);
+    }
+
+    public async Task WhenClassInitializeIsOnAbstractClassMarkedWithTestClass_AndWithInheritanceBehaviorNone_Diagnostic()
+    {
+        string code = """
+            using Microsoft.VisualStudio.TestTools.UnitTesting;
+
+            [TestClass]
+            public abstract class MyTestClass
+            {
+                [ClassInitialize(InheritanceBehavior.None)]
+                public static void [|ClassInitialize|](TestContext testContext)
+                {
+                }
+            }
+            """;
+
+        await VerifyCS.VerifyAnalyzerAsync(code);
+    }
 }