-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update description for (init/cleanup) analyzers #3391
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still incomplete. Maybe the best is to copy what appears on the doc page (e.g. https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0012)
@Evangelink https://github.com/microsoft/testfx/blob/main/src/Analyzers/MSTest.Analyzers/Helpers/FixtureUtils.cs#L50 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit, could you have keywords and types surrounded by single quotes please. Otherwise LGTM
# Conflicts: # src/Analyzers/MSTest.Analyzers/xlf/Resources.cs.xlf # src/Analyzers/MSTest.Analyzers/xlf/Resources.de.xlf # src/Analyzers/MSTest.Analyzers/xlf/Resources.es.xlf # src/Analyzers/MSTest.Analyzers/xlf/Resources.fr.xlf # src/Analyzers/MSTest.Analyzers/xlf/Resources.ja.xlf # src/Analyzers/MSTest.Analyzers/xlf/Resources.ko.xlf # src/Analyzers/MSTest.Analyzers/xlf/Resources.pl.xlf # src/Analyzers/MSTest.Analyzers/xlf/Resources.pt-BR.xlf # src/Analyzers/MSTest.Analyzers/xlf/Resources.ru.xlf # src/Analyzers/MSTest.Analyzers/xlf/Resources.tr.xlf # src/Analyzers/MSTest.Analyzers/xlf/Resources.zh-Hans.xlf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @engyebrahim!
fix: #3323