Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update description for (init/cleanup) analyzers #3391

Merged
merged 6 commits into from
Aug 2, 2024
Merged

Conversation

engyebrahim
Copy link
Member

fix: #3323

@Evangelink Evangelink changed the title Updater description for (init/cleanup) rule analysers Update description for (init/cleanup) analyzers Aug 2, 2024
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still incomplete. Maybe the best is to copy what appears on the doc page (e.g. https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0012)

@engyebrahim
Copy link
Member Author

Evangelink
Evangelink previously approved these changes Aug 2, 2024
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, could you have keywords and types surrounded by single quotes please. Otherwise LGTM

# Conflicts:
#	src/Analyzers/MSTest.Analyzers/xlf/Resources.cs.xlf
#	src/Analyzers/MSTest.Analyzers/xlf/Resources.de.xlf
#	src/Analyzers/MSTest.Analyzers/xlf/Resources.es.xlf
#	src/Analyzers/MSTest.Analyzers/xlf/Resources.fr.xlf
#	src/Analyzers/MSTest.Analyzers/xlf/Resources.ja.xlf
#	src/Analyzers/MSTest.Analyzers/xlf/Resources.ko.xlf
#	src/Analyzers/MSTest.Analyzers/xlf/Resources.pl.xlf
#	src/Analyzers/MSTest.Analyzers/xlf/Resources.pt-BR.xlf
#	src/Analyzers/MSTest.Analyzers/xlf/Resources.ru.xlf
#	src/Analyzers/MSTest.Analyzers/xlf/Resources.tr.xlf
#	src/Analyzers/MSTest.Analyzers/xlf/Resources.zh-Hans.xlf
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @engyebrahim!

@Evangelink Evangelink enabled auto-merge (squash) August 2, 2024 13:35
@Evangelink Evangelink merged commit e33fe79 into main Aug 2, 2024
6 checks passed
@Evangelink Evangelink deleted the Enji/fix-desc branch August 2, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

undocumented/implicit [TestClass]/abstract requirement for MSTEST0008 (an maybe possible others)
2 participants