Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use GetExceptionMessage instead of ex.Message in TestDataSource #3415

Merged
merged 3 commits into from
Aug 4, 2024
+2 −2
Merged

use GetExceptionMessage instead of ex.Message in TestDataSource #3415

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b435679
use GetExceptionMessage instead of ex.Message in TestDataSource
SimonCropp Aug 3, 2024
f4a98d7
Merge branch 'main' into use-GetExceptionMessage-instead-of-ex.Messag…
SimonCropp Aug 4, 2024
5bf9b94
Merge branch 'main' into use-GetExceptionMessage-instead-of-ex.Messag…
SimonCropp Aug 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Adapter/MSTestAdapter.PlatformServices/Services/TestDataSource.cs
View file
Original file line number Diff line number Diff line change
@@ -77,11 +77,11 @@ public class TestDataSource : ITestDataSource
}
catch (Exception ex)
{
string message = ExceptionExtensions.GetExceptionMessage(ex);
string message = ex.GetExceptionMessage();

// TODO: Change exception type to more specific one.
#pragma warning disable CA2201 // Do not raise reserved exception types
throw new Exception(string.Format(CultureInfo.CurrentCulture, Resource.UTA_ErrorDataConnectionFailed, ex.Message), ex);
throw new Exception(string.Format(CultureInfo.CurrentCulture, Resource.UTA_ErrorDataConnectionFailed, message), ex);
#pragma warning restore CA2201 // Do not raise reserved exception types
}
#else