MSTEST0003: Add code fix #3493
Merged
MSTEST0003: Add code fix #3493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Analyzers/MSTest.Analyzers.CodeFixes/CodeFixResources.Designer.cs # src/Analyzers/MSTest.Analyzers.CodeFixes/CodeFixResources.resx # src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.cs.xlf # src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.de.xlf # src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.es.xlf # src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.fr.xlf # src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.it.xlf # src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.ja.xlf # src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.ko.xlf # src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.pl.xlf # src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.pt-BR.xlf # src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.ru.xlf # src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.tr.xlf # src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.zh-Hans.xlf # src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.zh-Hant.xlf
Evangelink
reviewed
Aug 8, 2024
Evangelink
reviewed
Aug 8, 2024
There was a problem hiding this comment.
The code fix looks fine. As you do need the semantic model for some part of the fixes, I think you could drastically symplify the code by reusing some part of FixtureMethodFixer.cs
src/Analyzers/MSTest.Analyzers.CodeFixes/TestMethodShouldBeValidCodeFix.cs
Outdated
Show resolved
Hide resolved
Evangelink
reviewed
Aug 8, 2024
src/Analyzers/MSTest.Analyzers/TestMethodShouldBeValidAnalyzer.cs
Outdated
Show resolved
Hide resolved
Evangelink
reviewed
Aug 8, 2024
test/UnitTests/MSTest.Analyzers.UnitTests/TestMethodShouldBeValidAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
Evangelink
reviewed
Aug 9, 2024
src/Analyzers/MSTest.Analyzers.CodeFixes/TestMethodShouldBeValidCodeFix.cs
Outdated
Show resolved
Hide resolved
Evangelink
previously approved these changes
Aug 9, 2024
Evangelink
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #3396