Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Guard from Polyfill #3508

Merged
merged 12 commits into from
Aug 12, 2024
Merged

use Guard from Polyfill #3508

merged 12 commits into from
Aug 12, 2024

Conversation

SimonCropp
Copy link
Contributor

No description provided.

Evangelink
Evangelink previously approved these changes Aug 9, 2024
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please define global using in the csproj?

@Evangelink
Copy link
Member

I have triggered sync of the package, I'll update the PR once it's done

@Evangelink Evangelink enabled auto-merge (squash) August 12, 2024 07:39
@Evangelink
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Evangelink
Copy link
Member

Alright so tests are failing because we force the locally built version of the platform that contains a breaking change (ArgumentGuard is gone). So I'll force merge and skip tests and do the roundtrip insertion.

@Evangelink Evangelink disabled auto-merge August 12, 2024 15:19
@Evangelink Evangelink merged commit d8dd4d9 into microsoft:main Aug 12, 2024
1 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants