Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for testconfig.json entries in MSTest #3872

Merged
merged 89 commits into from
Oct 15, 2024
Merged

Conversation

engyebrahim
Copy link
Member

@engyebrahim engyebrahim commented Sep 26, 2024

fix: #3572


// Expected format of the json is: -
//
// "mstest" : {
//  "timeout" : {
//      "assemblyInitialize" : strictly positive int,
//      "assemblyCleanup" : strictly positive int,
//      "classInitialize" : strictly positive int,
//      "classCleanup" : strictly positive int,
//      "testInitialize" : strictly positive int,
//      "testCleanup" : strictly positive int,
//      "test" : strictly positive int
 //      "useCooperativeCancellation" : true/false
//  },
//  "parallelism" : {
//      "enabled": true/false,
//      "workers": positive int,
//      "scope": method/class,
//  },
//  "execution": {
//     "collectSourceInformation": true,
//     "executionApartmentState": "STA",
//     "disableAppDomain": true,
//     "mapInconclusiveToFailed" : true,
//     "mapNotRunnableToFailed" : true,
//     "treatDiscoveryWarningsAsErrors" : true,
//     "considerEmptyDataSourceAsInconclusive" : true,
//     "treatClassAndAssemblyCleanupWarningsAsErrors" : true,
//     "considerFixturesAsSpecialTests" : true,
//  },
//  "deployment" : {
//       "enabled": true / false,
//       "deployTestSourceDependencies": true / false,
//       "deleteDeploymentDirectoryAfterTestRunIsComplete": true / false
//  },
//  "assemblyResolution" : [
//        { "path" : "..." , includeSubDirectories: "true" } ,
//        { "path" : "..." , includeSubDirectories: "true" } ,
//        { "path" : "..." , includeSubDirectories: "true" } ,
//        ...
//     ],
//  ... remaining settings
// }

@engyebrahim
Copy link
Member Author

engyebrahim commented Oct 2, 2024

we have that by default generated
image

so as runsettings file could have some other settings more than mstest should i change the check to search on the key 'key' and throw on the case of it has it and we has it in configration but other than tat we okay two have two files!

check also visual studio default setting

@engyebrahim
Copy link
Member Author

engyebrahim commented Oct 2, 2024

i didn't use MSTESTv2 key

and for deployment settings it's in onother file/flow and i'm on it to get it from config

@engyebrahim
Copy link
Member Author

engyebrahim commented Oct 2, 2024

Directory pathes check if they need more work because of escaping

@engyebrahim engyebrahim marked this pull request as ready for review October 11, 2024 11:07
Evangelink
Evangelink previously approved these changes Oct 14, 2024
@@ -31,6 +31,7 @@

<ItemGroup>
<ProjectReference Include="$(RepoRoot)src\TestFramework\TestFramework.Extensions\TestFramework.Extensions.csproj" />
<ProjectReference Include="$(RepoRoot)src\Platform\Microsoft.Testing.Extensions.VSTestBridge\Microsoft.Testing.Extensions.VSTestBridge.csproj" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to use the Iconfiguration from the bridge

@Evangelink Evangelink merged commit 3bd098d into main Oct 15, 2024
6 checks passed
@Evangelink Evangelink deleted the enji/config branch October 15, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for testconfig.json entries in MSTest
3 participants