Fix MSTEST0036 is shown for cases where no shadowing happens #3881
Conversation
| @@ -112,7 +112,8 @@ private static bool IsMemberShadowing(ISymbol member, ISymbol baseMember) | |||
| } | |||
|
|
|||
| // Compare methods | |||
| if (member is IMethodSymbol methodSymbol && baseMember is IMethodSymbol baseMethodSymbol) | |||
| if (member is IMethodSymbol methodSymbol && baseMember is IMethodSymbol baseMethodSymbol && methodSymbol.IsGenericMethod == baseMethodSymbol.IsGenericMethod | |||
| && !(methodSymbol.DeclaredAccessibility == Accessibility.Private && baseMethodSymbol.DeclaredAccessibility == Accessibility.Private)) | |||
There was a problem hiding this comment.
It also can't be shadowing if only one of the methods is private, or can it?
There was a problem hiding this comment.
You are right, I find the syntax confusing but @engyebrahim added the not before the parenthesis so the and clause becomes a or :)
There was a problem hiding this comment.
- private and private:
!(true && true) = false(ok) - public and public:
!(false && false) = true(ok) - private and public:
!(true && false) = true(not ok, is not shadowing)
And I think the visibility check also needs to happen in the "Compare properties" section below.
There was a problem hiding this comment.
Oh yeah good point, I overlooked last case. @engyebrahim can you please add more tests and probably fix the remaining broken part?
There was a problem hiding this comment.
public&public raises
public&private raises
private&private doesn't raise
private&public doesn't raise -> fixing that case
fix: #3824