Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix casing for event key value #3915

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

MarcoRossignoli
Copy link
Contributor

@MarcoRossignoli MarcoRossignoli commented Oct 4, 2024

This pull request includes a change to the JsonRpcStrings class in the JsonRpcMethods.cs file to standardize the casing of the EventName constant.

Standardization of constant naming:

cc: @drognanar

Evangelink
Evangelink previously approved these changes Oct 4, 2024
@Evangelink
Copy link
Member

Shall we backport this to 1.4.2? Otherwise we will only start collecting telemetry from the next release (in some time).

cc @pavelhorak

@pavelhorak
Copy link
Member

Shall we backport this to 1.4.2? Otherwise we will only start collecting telemetry from the next release (in some time).

cc @pavelhorak

I'd prefer so

@MarcoRossignoli MarcoRossignoli merged commit ef98ab4 into microsoft:main Oct 4, 2024
4 of 6 checks passed
@MarcoRossignoli MarcoRossignoli deleted the dev/mr/eventname branch October 4, 2024 15:35
Evangelink pushed a commit that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants