Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially improve CollectionAssert message #4027

Merged

Conversation

Youssef1313
Copy link
Member

It still doesn't give the complete info as requested in #334

@Youssef1313 Youssef1313 force-pushed the partial-assert-message-improvement branch from 3fa7640 to 0ef3a45 Compare November 8, 2024 16:04
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to have actual and expected on new lines and not surrounded by quotes because for most complex data it could render weirdly.

@nohwnd I don't recall if your idea of expected/actual as exception data is already supported in TE or VSTest. If that's the case, it could be better than doing it explicitly (as done here).

@Youssef1313 Could we add a few tests?

Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to have actual and expected on new lines and not surrounded by quotes because for most complex data it could render weirdly.

@nohwnd I don't recall if your idea of expected/actual as exception data is already supported in TE or VSTest. If that's the case, it could be better than doing it explicitly (as done here).

@Youssef1313 Could we add a few tests?

Evangelink
Evangelink previously approved these changes Nov 19, 2024
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last readability nit and LGTM, thanks @Youssef1313

Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome :shipit:

@Evangelink Evangelink enabled auto-merge (squash) November 19, 2024 09:33
@Evangelink Evangelink merged commit 9cb5ec7 into microsoft:main Nov 19, 2024
6 checks passed
@Youssef1313 Youssef1313 deleted the partial-assert-message-improvement branch November 19, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants