New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce alloc in GetStackTraceInformation #4367

Merged

Dec 17, 2024

-Original file line number
+Diff line change
@@ Expand Up / @@ -77,18 +77,22 @@ @@
             bool first = true;
             while (stackTraces.Count != 0)
             {
-                result.AppendFormat(
-                        CultureInfo.CurrentCulture,
-                        "{0} {1}{2}",
-                        first ? string.Empty : (Resource.UTA_EndOfInnerExceptionTrace + Environment.NewLine),
-                        stackTraces.Pop(),
-                        Environment.NewLine);
+                if (!first)
+                {
+                    result.Append(utaEndOfInnerExceptionTrace);
+                }
+                result.Append(' ');
+                result.AppendLine(stackTraces.Pop());
                 first = false;
             }
             return CreateStackTraceInformation(ex, true, result.ToString());
         }
+        private static readonly string utaEndOfInnerExceptionTrace = Resource.UTA_EndOfInnerExceptionTrace + Environment.NewLine;
         /// <summary>
         /// Removes all stack frames that refer to Microsoft.VisualStudio.TestTools.UnitTesting.Assertion.
         /// </summary>
@@ Expand Down @@

Provide feedback