Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ExpectedException analyzer message/description to use the new Assert.Throws methods (and fix typo) #4527

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

Youssef1313
Copy link
Member

No description provided.

Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you are changing more than what the PR title says. Please fix content or title.

@Youssef1313 Youssef1313 force-pushed the expectedex-resources branch from 47dbe0d to 5d4f72b Compare January 6, 2025 13:28
@Youssef1313 Youssef1313 changed the title Update ExpectedException analyzer message/description to use the new Assert.Throws methods Update ExpectedException analyzer message/description to use the new Assert.Throws methods (and fix typo) Jan 6, 2025
@Evangelink Evangelink enabled auto-merge (squash) January 6, 2025 13:28
@Youssef1313
Copy link
Member Author

The other extra changes were mostly already done in AreNotSame. They unintentionally ended up in this branch. Rebasing made them go away, and also adjusted the PR title as I also fixed a typo in the messages I'm modifying.

@Youssef1313
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Evangelink Evangelink merged commit 5248f5d into microsoft:main Jan 6, 2025
10 checks passed
@Youssef1313 Youssef1313 deleted the expectedex-resources branch January 6, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants