Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TestDataRow class #4930

Merged
merged 22 commits into from
Feb 11, 2025
Merged

Add TestDataRow class #4930

merged 22 commits into from
Feb 11, 2025
+482 −194

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Feb 6, 2025 •
edited
Loading

Fixes #2227

@Youssef1313
Add TestDataRow class
Loading
Loading status checks…
45a82be
@Youssef1313
Use string literal for now
Loading
Loading status checks…
0ebbe7f
@Youssef1313
Refactor: Extract CreateIgnoredResult method
Loading
Loading status checks…
c6335e8
@Evangelink Evangelink marked this pull request as ready for review February 7, 2025 13:16
Evangelink
Evangelink reviewed Feb 7, 2025
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do another full pass review later on.

@Youssef1313
Copy link
Member Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Youssef1313 Youssef1313 mentioned this pull request Feb 10, 2025
Closed
@Youssef1313
Copy link
Member Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Youssef1313
Copy link
Member Author

Youssef1313 commented Feb 10, 2025 •
edited
Loading

Test is failing on .NET Framework and Debug only 😕
Taking a look

@Youssef1313
Copy link
Member Author

Standard output for the failure:

skipped TestDataRowSingleParameterFolded ("TestDataRowSingleParameterFolded - Ignoring") (0ms)
Ignore reason for second row - TestDataRowSingleParameterFolded
skipped Display name for third row - TestDataRowSingleParameterFolded (0ms)
Ignore reason for third row - TestDataRowSingleParameterFolded
[+2/x0/?2] DynamicData.exe (net462|x64) - TestDataRowSingleParameterUnfolded ("TestDataRowSingleParameterUnfolded - Only setting value") (2s)
skipped TestDataRowSingleParameterUnfolded ("TestDataRowSingleParameterUnfolded - Ignoring") (0ms)
Ignore reason for second row - TestDataRowSingleParameterUnfolded
skipped Display name for third row - TestDataRowSingleParameterUnfolded (0ms)
Ignore reason for third row - TestDataRowSingleParameterUnfolded
skipped Display name for fourth row - TestDataRowSingleParameterUnfolded (0ms)
Ignore reason for third row - TestDataRowSingleParameterUnfolded
skipped TestDataRowTwoParametersFolded ("TestDataRowTwoParametersFolded - Ignoring1","Ignoring2") (0ms)
Ignore reason for second row - TestDataRowTwoParametersFolded
skipped Display name for third row - TestDataRowTwoParametersFolded (0ms)
Ignore reason for third row - TestDataRowTwoParametersFolded
skipped TestDataRowTwoParametersUnfolded ("TestDataRowTwoParametersUnfolded - Ignoring1","Ignoring2") (0ms)
Ignore reason for second row - TestDataRowTwoParametersUnfolded
skipped Display name for third row - TestDataRowTwoParametersUnfolded (0ms)
Ignore reason for third row - TestDataRowTwoParametersUnfolded
skipped Display name for fourth row - TestDataRowTwoParametersUnfolded (0ms)
Ignore reason for third row - TestDataRowTwoParametersUnfolded
skipped TestDataRowParameterIsTupleFolded ((TestDataRowParameterIsTupleFolded - Ignoring1, Ignoring2)) (0ms)
Ignore reason for second row - TestDataRowParameterIsTupleFolded
skipped Display name for third row - TestDataRowParameterIsTupleFolded (0ms)
Ignore reason for third row - TestDataRowParameterIsTupleFolded
skipped TestDataRowParameterIsTupleUnfolded ((TestDataRowParameterIsTupleUnfolded - Ignoring1, Ignoring2)) (0ms)
Ignore reason for second row - TestDataRowParameterIsTupleUnfolded
skipped Display name for third row - TestDataRowParameterIsTupleUnfolded (0ms)
Ignore reason for third row - TestDataRowParameterIsTupleUnfolded
skipped Display name for fourth row - TestDataRowParameterIsTupleUnfolded (0ms)
Ignore reason for third row - TestDataRowParameterIsTupleUnfolded

@Evangelink Is the [+2/x0/?2] DynamicData.exe (net462|x64) - part expected? Meanwhile, I'll restart the job to understand if it's just flakiness

Evangelink
Evangelink reviewed Feb 11, 2025
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's create another ticket to not forget to implement the remaining optional properties/attributes

@Evangelink Evangelink enabled auto-merge (squash) February 11, 2025 10:05
@Evangelink Evangelink merged commit d7ec23d into microsoft:main Feb 11, 2025
8 checks passed
@Youssef1313 Youssef1313 deleted the testdatarow-class branch February 11, 2025 10:47
@Evangelink Evangelink mentioned this pull request Mar 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink

@MarcoRossignoli MarcoRossignoli

Assignees
No one assigned
Labels
Area: Parameterized tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide custom data type to hold data source entries
2 participants
@Youssef1313 @Evangelink