Preserve TestIdGenerationStrategy in the execution AppDomain #4942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….UnitTesting.TestIdGenerationStrategy'
Evangelink
approved these changes
Feb 8, 2025
|
@Evangelink This is not working as intended. I'll need to investigate again. But generally, the value is never set on the main AppDomain. We create an appdomain for discovery, and another for execution. What I have done flows from the main AppDomain. But the correct value was set in discovery appdomain. I think we will need one more change to set the value even earlier, if possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3053, Fixes #4941