Cleanup seemingly unnecessary complexity around TestAssemblySettingsProvider
#4951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4951 +/- ##
=======================================
Coverage 63.90% 63.91%
=======================================
Files 600 600
Lines 35986 36035 +49
=======================================
+ Hits 22998 23030 +32
- Misses 12988 13005 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Youssef1313
commented
Feb 10, 2025
|
|
||
| try | ||
| { | ||
| sourceSettingsProvider = isolationHost.CreateInstanceForType( |
There was a problem hiding this comment.
We previously were creating an instance of TestAssemblySettingsProvider in a separate AppDomain, but we did "nothing" with it other than a null check. Then we simply call TestAssemblySettingsProvider.GetSettings
|
Replacing with #4952 |
Youssef1313
deleted the
dev/ygerges/cleanup-TestAssemblySettingsProvider
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.