Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestFailedException outcome not propagating to TestResult outcome #5236

Merged
merged 2 commits into from
Mar 15, 2025

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Mar 14, 2025

Fixes #5226

Looks like it could be a regression from #4686

@Youssef1313 Youssef1313 force-pushed the dev/ygerges/fix-inconclusive branch from 0c7ec57 to 9be521d Compare March 14, 2025 12:27
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.46%. Comparing base (f8b718b) to head (b1c677c).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5236      +/-   ##
==========================================
+ Coverage   75.41%   75.46%   +0.04%     
==========================================
  Files         600      600              
  Lines       36752    36752              
==========================================
+ Hits        27718    27736      +18     
+ Misses       9034     9016      -18     
Flag Coverage Δ
Debug 75.46% <100.00%> (+0.04%) ⬆️
integration 75.46% <100.00%> (+0.04%) ⬆️
production 75.46% <100.00%> (+0.04%) ⬆️
unit 75.46% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...pter/MSTest.TestAdapter/Execution/TestClassInfo.cs 82.91% <100.00%> (+0.62%) ⬆️
...ter/MSTest.TestAdapter/Execution/UnitTestRunner.cs 96.19% <100.00%> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Youssef1313 Youssef1313 merged commit eba5fbb into main Mar 15, 2025
8 checks passed
@Youssef1313 Youssef1313 deleted the dev/ygerges/fix-inconclusive branch March 15, 2025 19:56
@Youssef1313
Copy link
Member Author

/backport to rel/3.8

Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSTest - ClassInitialize - Assert.Inconclusive fails the workflow on MSTest 3.8.2, but not on 3.7.3
3 participants