Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg-scripts] Update to CMake 4.0.0-rc3 #44273

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[vcpkg-scripts] Update to CMake 4.0.0-rc3 #44273

wants to merge 3 commits into from
+30 −26

Conversation

Neumann-A
Copy link
Contributor

@Neumann-A Neumann-A commented Mar 9, 2025 •
edited by jimwang118
Loading

Fixes #43816

@Neumann-A
Copy link
Contributor Author

@BillyONeal Is it intended that CI is not printing the actual download failure due to the hash mismatch (since the hash has only be updated for windows & amd64)?

@jimwang118 jimwang118 self-assigned this Mar 10, 2025
@jimwang118 jimwang118 added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Mar 10, 2025
@jimwang118 jimwang118 mentioned this pull request Mar 11, 2025
Closed
7 tasks
@BillyONeal
Copy link
Member

@BillyONeal Is it intended that CI is not printing the actual download failure due to the hash mismatch (since the hash has only be updated for windows & amd64)?

I'm not sure I understand the question. It won't report failures to download things it never attempts to download.

@Neumann-A
Copy link
Contributor Author

I'm not sure I understand the question. It won't report failures to download things it never attempts to download.

I updated the version to 4.0.0-rc3 so shouldn't it always attempt to download that version? However, it just gives an error that it cannot find cmake where it expects it to find it. I expected it to print a hash mismatch error instead. Ah maybe that is the same issue as everywhere that it does not download it if there is a hash match because i didn't set it to 0.

@Neumann-A Neumann-A mentioned this pull request Mar 13, 2025
Draft
7 tasks
@autoantwort
Copy link
Contributor

It first tries to download the thing through the asset cache via the given sha, if this fails it tries to download from the original url.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jimwang118 jimwang118

Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[qtgraphs] Build failure on x64-windows due to CMake Version
4 participants
@Neumann-A @BillyONeal @autoantwort @jimwang118