Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct port forwarding terminology to reverse port forwarding #8169

Merged
merged 4 commits into from
Mar 24, 2025

Conversation

ehabAbdelMawla
Copy link
Contributor

@ehabAbdelMawla ehabAbdelMawla commented Mar 22, 2025

The current documentation labels the port forwarding feature as "Local Port Forwarding," which suggests tunneling from a local machine to a remote service. However, the described behavior—exposing a local service (e.g., port 5555 on the user's machine) to the internet via a public URL—is reverse port forwarding. This PR updates the title and , aligning with standard networking definitions. The change clarifies that it exposes local services externally, not the other way around, and adjusts the remote machine question for consistency.

Copy link
Contributor

@ntrogh ntrogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehabAbdelMawla thanks for bringing this up. We're actually planning on changing the article title to just "Port forwarding" as this also matches what is shown in the user interface.
Do you want to make this change, otherwise I'll go ahead and close this PR and apply the changes.

@ehabAbdelMawla ehabAbdelMawla requested a review from ntrogh March 24, 2025 22:12
@ehabAbdelMawla
Copy link
Contributor Author

@ntrogh Thanks for the clarification! I've already updated my PR to reflect this change.

@ehabAbdelMawla ehabAbdelMawla requested a review from ntrogh March 24, 2025 22:29
Copy link
Contributor

@ntrogh ntrogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehabAbdelMawla Thanks. Appreciate your contribution!

@ntrogh ntrogh merged commit 0a30f64 into microsoft:main Mar 24, 2025
1 check passed
@vs-code-engineering vs-code-engineering bot added this to the March 2025 milestone Mar 24, 2025
yoyohoney857 added a commit to yoyohoney857/vscode-docs that referenced this pull request Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants