Unable to see comments in commits file view

[miguelsolorio]

Refs microsoft/vscode#122245

I'm unsure if this is expected or not, but I at least expected to see the same comments from the Files section appear under the file in the Commits section as well

Files

Commits

GH PR Version: v2021.4.39423
Version: 1.56.0-insider (user setup)
Commit: 13f1afffab09548c10ddb3bc5d5db52587876ad8
Date: 2021-04-28T04:52:06.990Z
Electron: 12.0.4
Chrome: 89.0.4389.114
Node.js: 14.16.0
V8: 8.9.255.24-electron.0
OS: Windows_NT x64 10.0.19042

[alexr00]

Comments that were made when your PR was on the commit that you have selected should now show.

[miguelsolorio]

I'm seeing a couple of issues, not sure if they're related to this. When trying to check out the PR from the overview page, I get a "branch not found" error. Then when I manually change to the branch and attempt to open the commit file, I get a "couldn't find commit"

GHPR: v2021.6.42304
Version: 1.58.0-insider (Universal)
Commit: 57930758db9e2c83f59b9ee1851400bd16192d32
Date: 2021-06-30T05:13:11.659Z
Electron: 12.0.12
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: 8.9.255.25-electron.0
OS: Darwin arm64 20.5.0

---

While on Windows I don't see these issues but then the original issue still repros.

[alexr00]

Opened a new issue for the checkout from overview issue: #2812

@misolori I'm able to see comments in files opened from the commits tree. Note that each comment will only show on one of the commits. Comments are mapped to commits, so each comment will only show in the commit for which that comment was added. (the commit hash isn't shown in the tree right now, I will add that in the hover for July since it seems useful). Can you double check that you had the commit that the comment was associated with open?

[miguelsolorio]

I'm still seeing this, here's another PR example:

Opening file

✅ This shows the comment

Opening the commit

❌ This does not show any commits even though there is 💬 icon on the file

[miguelsolorio]

I guess the question really is: should i be able to see comments from the commits node in addition to the files node? If not then we should hide the 💬 icon from that item in that node as it's confusing.

[rzhao271]

I'll mark this issue as verification found again based on Miguel's question above.

[alexr00]

I can repro with the PR that Miguel was testing with.

[alexr00]

The issue is that the comments associated with the most recent commit will not show in that commit. Fix doesn't look low risk, so moving to July.