Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quote reply doesn't handle nested replies #3059

Closed
diminutivesloop opened this issue Oct 22, 2021 · 1 comment · Fixed by #3148
Closed

quote reply doesn't handle nested replies #3059

diminutivesloop opened this issue Oct 22, 2021 · 1 comment · Fixed by #3148
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@diminutivesloop
Copy link

diminutivesloop commented Oct 22, 2021

Issue Type: Bug

Steps to Reproduce:

  1. Click the "Quote Reply" button for a PR comment that quote-replies to another comment.
  2. Click the "Comment" button.

Result:
The original comment is nested inside two quote boxes, while the previous quote-reply text is unquoted.
Screen Shot 2021-10-22 at 1 11 41 PM

Extension version: 0.31.1
VS Code version: Code 1.61.2 (Universal) (6cba118ac49a1b88332f312a8f67186f7f3c1643, 2021-10-19T15:49:28.381Z)
OS version: Darwin x64 20.6.0
Restricted Mode: No

System Info
Item Value
CPUs Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 x 2600)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 3, 3, 3
Memory (System) 32.00GB (0.16GB free)
Process Argv --crash-reporter-id ed50f89e-497f-43cd-86f3-a73119f730ed
Screen Reader no
VM 0%
A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30300192
pythontb:30283811
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscoreces:30384385
pythondataviewer:30285071
pythonvsuse255:30340121
vscod805cf:30301675
pythonvspyt200:30340761
binariesv615:30325510
vsccppwt:30382697
pythonvssor306:30344512
bridge0708:30335490
pygetstartedt3:30385195
dockerwalkthru:30377721
bridge0723:30353136
pythonrunftest32:30373476
pythonf5test824:30373475
javagetstartedc:30364665
pythonvspyt187:30373474
vsqsis300:30381676
vsaa593cf:30376535
vssld246:30379911

@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Oct 28, 2021
@alexr00 alexr00 self-assigned this Oct 28, 2021
@alexr00 alexr00 added this to the November 2021 milestone Oct 28, 2021
@alexr00
Copy link
Member

alexr00 commented Oct 28, 2021

@burkeholland this could be another good one for you!

alexr00 added a commit that referenced this issue Nov 30, 2021
@rzhao271 rzhao271 added the verified Verification succeeded label Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants