In review mode, the "Active Pull Request" panel contains another Pull Request

[faustnord]

• Extension version: v0.40.0
• VSCode Version: 1.66.2 (Universal)
• OS: macOS Monterey 12.3.1

Steps to Reproduce:

Such non-obvious behavior leads to bad consequences. You think you're approving, commenting, or merging one branch (which you switched to), when in fact you're doing these actions on a completely different branch that you were working on before.

We've already gotten into trouble with this bug and accidentally merged a completely different branch that hasn't been finalized yet.

[dslatkin]

Such non-obvious behavior leads to bad consequences. You think you're approving, commenting, or merging one branch (which you switched to), when in fact you're doing these actions on a completely different branch that you were working on before.

We've already gotten into trouble with this bug and accidentally merged a completely different branch that hasn't been finalized yet.

Not sure if it's related, but there's a similar issue in #3490 where there's a mismatch in the PRs displayed in the "Changes in pull request" and "Active pull request" panels. We've also been bitten with comments and approvals going to the wrong PRs. 🙁

[alexr00]

Thank you for the very clear repro steps! This looks like #3431.

I tried the steps with the current pre-release build of the extension (which has the fix for #3431), and wasn't able to reproduce the issue. If you're willing to try it out, instructions for using the pre-release build are very simple and are here: https://github.com/microsoft/vscode-pull-request-github/wiki/Pre-release-Build

[faustnord]

I checked it.
This now works correctly in VS Code 1.67.0 and extension version v0.42.0

[alexr00]

Thank you for testing this @faustnord!