Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active pull request doesn't match active pr panel #3431

Closed
rchiodo opened this issue Mar 23, 2022 · 4 comments · Fixed by #3456
Closed

Active pull request doesn't match active pr panel #3431

rchiodo opened this issue Mar 23, 2022 · 4 comments · Fixed by #3456
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@rchiodo
Copy link

rchiodo commented Mar 23, 2022

I have this PR open:

And the screen shows this:
image

The active pr panel is from another PR.

Attached the log output:
ghpri.txt

@rchiodo
Copy link
Author

rchiodo commented Mar 23, 2022

GH PR Extension version:
Name: GitHub Pull Requests and Issues
Id: GitHub.vscode-pull-request-github
Description: Pull Request and Issue Provider for GitHub
Version: 0.39.2022032309
Publisher: GitHub
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=GitHub.vscode-pull-request-github

@alexr00
Copy link
Member

alexr00 commented Mar 24, 2022

The Comments view will show comments from your currently open PR and from any PRs you've recently browsed but not checked out. Is that what you're seeing?

@alexr00 alexr00 added the info-needed Issue requires more information from poster label Mar 24, 2022
@rchiodo
Copy link
Author

rchiodo commented Mar 24, 2022

Sorry I named it the wrong thing. The bottom panel on the current PR showed the wrong PR data.

image

I thought this (at first) was where comments would show up because you can comment there, but it's not the comments panel (that shows up in the output tab).

It's the 'Active Pull Request' panel. It doesn't match the active pull request.

I just had it repro again:
image

You can tell because the PR numbers don't match.

@rchiodo rchiodo changed the title Active pull request doesn't match comment panel Active pull request doesn't match active pr panel Mar 24, 2022
@alexr00 alexr00 self-assigned this Mar 25, 2022
@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Mar 25, 2022
@alexr00 alexr00 added this to the April 2022 milestone Mar 25, 2022
@alexr00
Copy link
Member

alexr00 commented Apr 7, 2022

Steps to repro:

  1. Have a PR checked out.
  2. Reload
  3. Use the "Exit Review Mode" button to change branches
  4. Checkout a different PR from the PRs view and do not click on the GitHub Pull Request view, let it open on its own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants