User completion in commit box is wrong when manually triggered

[joaomoreno]

When typing @, I get suggestions for users, but once I typed a few characters pressing Ctrl D will show me issue suggestions.

[alexr00]

I think if you scroll down in that issues list you'll see the users below the issues. Since it wasn't triggered by a trigger character we show both.

[joaomoreno]

Correct, they are all there. But why is this useful behavior? In other words, why do all those suggestions appear as possibilities for the @sand input? Scrolling down, not even @sandy081 is highlighted in that case:

[joaomoreno]

The bug seems to be that the filtering only happens from the moment the widget pops up (either automatically or manually). Notice this example:

The widget only filters on the moreno sequence that I type after manually opening it and even fails to properly render highlights on user names.

The expected behavior is: when manually opening it, it should be filtered on my initial input (joao) and should further filter down as I type the rest (moreno). This is exactly how it works in the editor:

[alexr00]

This occurs for all suggests, not just in the commit box.

[alexr00]

@jrieken I think CompletionProvider would need to add some support for this. Is there a way for an extension to tell the suggest widget what text before the cursor should be used for filtering?

[jrieken]

Is there a way for an extension to tell the suggest widget what text before the cursor should be used for filtering?

Yes, it the CompletionItem#range property.

[joyceerhl]

In a codespace and desktop RemoteHub I get user suggestions in the commit box, but I can't trigger suggestions automatically or manually in web at all.

[alexr00]

Opened #4119 to fix.