Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some text is not visible in high contrast mode #4287

Closed
Thomas1664 opened this issue Dec 3, 2022 · 1 comment · Fixed by #4421
Closed

Some text is not visible in high contrast mode #4287

Thomas1664 opened this issue Dec 3, 2022 · 1 comment · Fixed by #4421
Assignees
@alexr00
Labels
accessibility bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
January 2023

Comments

@Thomas1664
Copy link
Contributor

Thomas1664 commented Dec 3, 2022 •
edited
Loading

To reproduce, change your theme to high contrast light.

The following UI is not visible in high contrast mode:

  • code blocks in comments on the description view (also need a border in high contrast mode)
  • code in comments is hard to distinguish from normal text
  • text of the comment button at the end of the description view (Fixed by UI fixes for PR view #4368)
@alexr00 alexr00 self-assigned this Dec 5, 2022
@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug accessibility labels Dec 5, 2022
@alexr00 alexr00 added this to the December 2022 milestone Dec 5, 2022
@alexr00
Copy link
Member

alexr00 commented Jan 20, 2023

code in comments is hard to distinguish from normal text

I didn't change this one as it's already using a VS Code color and it also has a different font.

@alexr00 alexr00 mentioned this issue Jan 20, 2023
Merged
alexr00 added a commit that referenced this issue Jan 20, 2023
@alexr00
Some text is not visible in high contrast mode
aef2e0f 
Fixes #4287
alexr00 added a commit that referenced this issue Jan 20, 2023
@alexr00
Some text is not visible in high contrast mode (#4421)
7d599ac 
Fixes #4287
@mjbvz mjbvz added the verified Verification succeeded label Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
accessibility bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
January 2023
Development

Successfully merging a pull request may close this issue.

Some text is not visible in high contrast mode microsoft/vscode-pull-request-github
3 participants
@mjbvz @alexr00 @Thomas1664