File filter/highlight in explorer misses some files

[akoeplinger]

Issue Type: Bug

The file highlighter which appears when you start typing in the explorer tree view misses some files.

Repro steps:

1. Extract the attached vscodebug.zip into a new folder and open it in Code
2. Start typing .ignore in the explorer
3. Notice how some file extensions are highlighted, while others are not
4. It seems to be inconsistent too since e.g. more files are highlighted when you just type .ign instead of the full word.

Screencast:

VS Code version: Code - Insiders 1.37.0-insider (894056d, 2019-07-15T05:24:02.940Z)
OS version: Darwin x64 18.6.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz (8 x 4200)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: enabled oop_rasterization: disabled_off protected_video_decode: unavailable_off rasterization: enabled skia_deferred_display_list: disabled_off skia_renderer: disabled_off surface_synchronization: enabled_on video_decode: enabled viz_display_compositor: disabled_off webgl: enabled webgl2: enabled
Load (avg)	1, 1, 2
Memory (System)	16.00GB (0.56GB free)
Process Argv	--disable-extensions /Users/alexander/dev/test/vscodebug
Screen Reader	no
VM	0%

Extensions disabled

[vscodebot]

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

[jrieken]

#74133

[akoeplinger]

@jrieken since that issue talks about autocomplete in the editor context I assume this is some shared component?

For the explorer it's more annoying since the matches also affect what's shown in the file filter (when you hover over the filter text and click the "Enable Filter on Type" icon).

I often use that filter to quickly edit all files with a certain extension and if I can't be confident it shows all the files then that feature is kinda useless. Having files longer than 54 chars is not that uncommon 😄