-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autocompletion is matched against truncated filterText to 54 characters #74133
Comments
Yeah - that's the current design and keep things fast. At some point a table is being populated and that's what we cap it. I agree that the limit is arbitrary but there some limit is required. We figured that few programming symbols have names that long and from your sample it seems that you are pushing it will headings... |
I think those limits should be clearly stated in the API documentation. It would really help extension maintainers. |
Can you please make this limit configurable, at least for custom language extensions, or just make it larger, like at least 128? I'm developing an extension for custom script syntax, and the goal was to allow filtering game NPCs scripts by either their map or part of their full name by making label a string of concatenated name and map. This short limit makes it impossible to do so. |
This is really unfortunate. For the scientific community, doing citations is a daily business. This funky behavior basically renders the citation search unusable. I sometimes have to go back to atom just to do citations. I think something small like this can drive people away with time. I second the proposal of making the limit customizable. |
I have increased the limit 128, let's see how far we get with that... |
When providing a list of
completionItem
with a non emptyfilterText
, it seems that when typing only the54
first characters offilterText
are considered.filterText
:RoWill2 Rogers, L. C. G. and William Diffusions, Markov processes, and martingales. Vol. 1 undefined
. Theo
ofMarkov
is in position54
(counting from0
).filterText
:RoWill3 Rogers, L. C. G. and Willia Diffusions, Markov processes, and martingales. Vol. 2 undefined
. Theo
ofMarkov
is in position53
(counting from0
).When typing
o
to narrow the completion toMarko
, the first entry vanishes.I apologise for not providing a reproducing example but I do not know how to simply provide a list of completions outside of an extension. I noticed this issue in LaTeX Workshop (I am a maintainer of it).
The text was updated successfully, but these errors were encountered: