Move FQN related code into a separate NuGet package #2714

Haplois · 2021-01-24T21:18:22Z

Description

As part of #2708:

Moved ManagedNameUtilities into a new project.
Removed hardcoded support from TestCase class to restore compatibility with older versions of TestPlatform.
Create a new NuGet package
Determine what to call Microsoft.TestPlatform.ManagedNames package. We're calling it Microsoft.TestPlatform.AdapterUtilities.
Fix Ubuntu build

Removed ManagedNameUtilities from ObjectModel in order to restore compatibility with older versions.

- NuGet package recipe for `Microsoft.TestPlatform.ManagedNames` added.

src/Microsoft.TestPlatform.ManagedNames/Extensions/ReflectionExtensions.cs

src/Microsoft.TestPlatform.ManagedNames/ManagedNameUtilities/Contants.cs

src/Microsoft.TestPlatform.ManagedNames/Extensions/TestCase2Extensions.cs

src/Microsoft.TestPlatform.ManagedNames/ManagedNameUtilities/ManagedNameParser.cs

src/Microsoft.TestPlatform.ObjectModel/TestCase.cs

- All references to `Microsoft.TestPlatform.ManagedNames` refactored as `Microsoft.TestPlatform.AdapterUtilities`.

shyamnamboodiripad · 2021-01-26T21:51:28Z

@Haplois @peterwald Can we now delete the Reflection-based implementation of FQN from the VSUnitTesting repo?

I would still like to ensure that the Reflection and Roslyn based implementations continue to align - so it would be great to preserve unit tests for the FQN functionality in VSUnitTesting repo (i.e. replace the Reflection implementation testted by the unit tests with the new MS.TP.AdapterUtilities nuget - but continue to reference Roslyn based implementation from the VSUnitTesting repo).

shyamnamboodiripad

👍🏾 modulo comments

shyamnamboodiripad · 2021-01-26T21:37:24Z

.gitignore

@@ -32,6 +32,7 @@ build*.log
 build*.wrn
 build*.err
 *.binlog
+*.svclog


In case you were wondering, there was a bug in some recent internal builds of VS that would cause svclog files to be dropped in devenv.exe's CWD. I believe that bug should be fixed now :)

...Microsoft.TestPlatform.AdapterUtilities/ManagedNameUtilities/ManagedNameHelper.Reflection.cs

src/Microsoft.TestPlatform.AdapterUtilities/Microsoft.TestPlatform.AdapterUtilities.csproj

src/package/nuspec/Microsoft.TestPlatform.AdapterUtilities.nuspec

src/Microsoft.TestPlatform.ObjectModel/TestCase.cs

shyamnamboodiripad · 2021-01-27T01:30:07Z

src/Microsoft.TestPlatform.AdapterUtilities/Microsoft.TestPlatform.AdapterUtilities.csproj

+
+  <PropertyGroup>
+    <TargetFrameworks>netstandard1.0;netstandard2.0</TargetFrameworks>
+    <TargetFrameworks Condition="'$(OS)' == 'Windows_NT'">$(TargetFrameworks);uap10.0;</TargetFrameworks>


Just an observation on something that is likely to come up in the future: Since managed test frameworks will probably require this reference to be added in their framework layer (as opposed to the VS / adapter layer) and since the framework layer will likely be consumed in older versions of VS (as well as outside of VS), test frameworks may end up needing to conditionally add package reference for MS.TP.AdapterUtilities to only a subset of their supported targets and / or conditionally opt in to the FQN functionality in their framework layer only in cases where they know that the caller is VS. Alternatively, if they can't consume the package they may need to maintain a parallel implementation of the FQN spec or copy the Reflection code from the current repo...

Haplois · 2021-01-27T14:30:40Z

I added net20 and net35 support to the code, it builds when using VS, but I am having some problems with .resx files. I also needed to do some MSBuild hacks to get it to compile using dotnet cli. See: dotnet/msbuild#5985

I'll keep the code that compiles under net20 and net35 but remove the target framework for now. This will be fixed in a future PR, hopefully.

/cc: @shyamnamboodiripad

AbhitejJohn

Concerned with the changes in OM. What does our test matrix look like?

scripts/build.ps1

src/Microsoft.TestPlatform.AdapterUtilities/Extensions/ReflectionExtensions.MethodBase.cs

src/Microsoft.TestPlatform.AdapterUtilities/Extensions/ReflectionExtensions.Type.cs

AbhitejJohn · 2021-01-27T14:31:57Z

src/Microsoft.TestPlatform.AdapterUtilities/Microsoft.TestPlatform.AdapterUtilities.csproj

+    <TargetPlatformVersion>10.0.14393.0</TargetPlatformVersion>
+    <TargetPlatformMinVersion>10.0.10240.0</TargetPlatformMinVersion>
+    <TargetFrameworkIdentifier>.NETPortable</TargetFrameworkIdentifier>
+    <TargetFrameworkVersion>v4.5</TargetFrameworkVersion>


Is this required? (v4.5)

I actually don't know. Without those properties, the UAP build fails. I am not an expert on that platform so just copied over from ObjectModel.

Weird, cause we are setting TFM to a different version below. So does this project target 4.5 or 4.5.1?

src/Microsoft.TestPlatform.CrossPlatEngine/Microsoft.TestPlatform.CrossPlatEngine.csproj

src/Microsoft.TestPlatform.ObjectModel/TestCase.cs

- Added `net20` and `net35` support to the code. - Other refactorings.

Haplois · 2021-01-27T14:54:21Z

We're removing new FQN features from ObjectModel since they were breaking compatibility. So the changes on ObjectModel should not affect any older releases. They didn't ship on a release yet. /cc: @AbhitejJohn

AbhitejJohn · 2021-01-27T14:56:44Z

@Haplois : Sounds great, thanks.

* Update dependencies from https://github.com/dotnet/arcade build 20201130.3 (#2659) Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild From Version 1.0.0-beta.20570.10 -> To Version 1.0.0-beta.20580.3 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Updating Microsoft.VisualStudio.TraceDataCollector source (#2663) * Getting Microsoft.VisualStudio.TraceDataCollector from CodeCoverageExternals instead of TestPlatformExternals, * Signing TraceDataCollector from the right path, * Removing already signed dlls, * Not signing corelib.net, * Removing files from the list as they are not present, Co-authored-by: faisal <[email protected]> * Fixed "issue" pluralization in write-release-notes.ps1 (#2665) * Fixed "issue" pluralization in write-release-notes.ps1 Co-authored-by: Medeni Baykal <[email protected]> * Bumping Fakes TestRunnerHarness version (#2661) * Implement Workitem support in TRX logger (#2666) * Implemented Workitem support in TRX logger * Renamed Workitem to WorkItem Co-authored-by: Flepp Jann <[email protected]> * Do not merge logs from code coverage (#2671) * Early testhost startup performance work (#2584) * Removed TypesToLoadAttribute from ObjectModel. (#2674) * Removed TypesToLoadAttribute from ObjectModel, and moved the functionallity into adapters themselves. * Attribute refactoring (#2676) * Getting TraceDataCollector from nuget (#2678) * Removing TraceDataCollector project, * Getting tracedatacollector from nuget, * Removing signing of codecoverage libs as they are already signed, updating codecoverage version, * fixing path to tracedatacollector, * Fixing acceptance tests, Co-authored-by: faisal <[email protected]> * Adding environment variable used during build process, (#2679) * Removing TraceDataCollector project, * Getting tracedatacollector from nuget, * Removing signing of codecoverage libs as they are already signed, updating codecoverage version, * fixing path to tracedatacollector, * Fixing acceptance tests, * Setting TraceDataCollectorPackagesDir vairable which is used in pipeline, * Fixing environment variable, * Fixing path, once again, Co-authored-by: faisal <[email protected]> * Update dependencies from https://github.com/dotnet/arcade build 20201221.2 (#2680) Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild From Version 1.0.0-beta.20580.3 -> To Version 1.0.0-beta.20621.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Upgrade CC and CLR IE versions (#2681) Co-authored-by: Jakub Chocholowicz <[email protected]> * Fixed assembly names of TestHost executables (#2682) * Upgrade fakes version (#2683) Co-authored-by: Jakub Chocholowicz <[email protected]> * Upgrade CC to 16.9.0-beta.20630.1 (#2684) Co-authored-by: Jakub Chocholowicz <[email protected]> * Loc Update (#2685) Co-authored-by: Cristiano Suzuki <[email protected]> * Create AzureDevOps.yml * Update AzureDevOps.yml * Update AzureDevOps.yml * Update AzureDevOps.yml * Delete AzureDevOps.yml * Fix nuget feed (#2697) * Removing deprecated mygets and adding new nuget sources * Upgrade CC components (#2698) * Upgrade CC components * Revert nuget changes * Refactor it Co-authored-by: Jakub Chocholowicz <[email protected]> * Update dependencies from https://github.com/dotnet/arcade build 20210113.4 (#2696) Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild From Version 1.0.0-beta.20621.2 -> To Version 1.0.0-beta.21063.4 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Create AzureDevOps.yml * Update AzureDevOps.yml * Update AzureDevOps.yml * Update AzureDevOps.yml * Update AzureDevOps.yml * Update AzureDevOps.yml * Update AzureDevOps.yml changed to my repo * Update AzureDevOps.yml * Add integration tests for dotnet test (#2689) * Add integration tests for dotnet test * Use relative paths and correct proj * Update to latest .NET 6 * Install 5.0.1 runtime * Add parametrized project * Updated build status badge. (#2709) * Updated build status badge. * Update dependencies from https://github.com/dotnet/arcade build 20210121.4 (#2712) Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild From Version 1.0.0-beta.21063.4 -> To Version 1.0.0-beta.21071.4 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/arcade build 20210122.7 (#2713) Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild From Version 1.0.0-beta.21063.4 -> To Version 1.0.0-beta.21072.7 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Medeni Baykal <[email protected]> * Update azure-pipelines.yml for Azure Pipelines (#2715) * Add metrics for datacollector.exe - provides information about profilers (#2705) * Initial version of metrics for DC profiling * Tests * Push fixes to make linux build * provide telemetry opted in flag * Small refactoring * Change name * Upgrade CC comp * Move to guids * Revert lang change * Fixing descriptions * Last changes Co-authored-by: Jakub Chocholowicz <[email protected]> * Added git branch and commit NuGet packages (#2716) * vstest.console: CommandLineOptions: preserve stacktrace on re-throw (CA2200) (#2606) * vstest.console: CommandLineOptions: preserve stacktrace on re-throw (CA2200) * Update AzureDevOps.yml * Update AzureDevOps.yml * Move FQN related code into a separate NuGet package (#2714) * Removed ManagedNameUtilities from ObjectModel in order to restore compatibility with older versions. * Added `Microsoft.TestPlatform.AdapterUtilities`. * Added `net20` and `net35` support to the code. * Including `Microsoft.TestPlatform.AdapterUtilities` in signing (#2719) * Included missing assemblies in signing. * Updating nuget Pdb2Pdb package (#2720) * Adding new Pdb2Pdb package and change to licence tag because of warning * Fixing license * Formating fixes Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: fhnaseer <[email protected]> Co-authored-by: faisal <[email protected]> Co-authored-by: Adam Ralph <[email protected]> Co-authored-by: Medeni Baykal <[email protected]> Co-authored-by: Vritant Bhardwaj <[email protected]> Co-authored-by: jflepp <[email protected]> Co-authored-by: Flepp Jann <[email protected]> Co-authored-by: Codrin-Victor Poienaru <[email protected]> Co-authored-by: Jakub Chocholowicz <[email protected]> Co-authored-by: Cristiano Suzuki <[email protected]> Co-authored-by: Cristiano Suzuki <[email protected]> Co-authored-by: Pavel Horak <[email protected]> Co-authored-by: Sanan Yuzbashiyev <[email protected]> Co-authored-by: Jakub Jareš <[email protected]> Co-authored-by: Tom Deseyn <[email protected]>

Haplois added 2 commits January 24, 2021 19:59

Added .svclog into gitignore

53daaf7

Removed ManagedNameUtilities from ObjectModel.

e97dcd1

Removed ManagedNameUtilities from ObjectModel in order to restore compatibility with older versions.

Haplois force-pushed the fqn-separation branch from 214cd50 to e97dcd1 Compare January 24, 2021 21:50

Haplois added 3 commits January 24, 2021 23:28

Added Microsoft.TestPlatform.ManagedNames.nuspec.

7f4dc4a

- NuGet package recipe for `Microsoft.TestPlatform.ManagedNames` added.

Fixed a typo in resource access.

25ad28f

Publish test results on failed builds.

34707d5

Haplois self-assigned this Jan 24, 2021

Haplois force-pushed the fqn-separation branch from d1fcd0e to d524e19 Compare January 24, 2021 23:19

Fixed failed tests.

0147287

Haplois force-pushed the fqn-separation branch from d524e19 to 0147287 Compare January 24, 2021 23:44

Merge branch 'master' into fqn-separation

a264470

Sanan07 reviewed Jan 25, 2021

View reviewed changes

PR recommendations applied.

dbdcc07

cvpoienaru reviewed Jan 25, 2021

View reviewed changes

peterwald approved these changes Jan 25, 2021

View reviewed changes

peterwald reviewed Jan 25, 2021

View reviewed changes

src/Microsoft.TestPlatform.ObjectModel/TestCase.cs Outdated Show resolved Hide resolved

Haplois added 3 commits January 26, 2021 01:44

Merged with master

1984701

Fixed non-windows builds.

1126030

Removed ManagedNames from TestCase

e28156b

Haplois marked this pull request as ready for review January 26, 2021 20:00

Package renamed to Microsoft.TestPlatform.AdapterUtilities.

78138e1

- All references to `Microsoft.TestPlatform.ManagedNames` refactored as `Microsoft.TestPlatform.AdapterUtilities`.

Haplois force-pushed the fqn-separation branch from 8459dd3 to 78138e1 Compare January 26, 2021 20:25

shyamnamboodiripad reviewed Jan 27, 2021

View reviewed changes

AbhitejJohn reviewed Jan 27, 2021

View reviewed changes

Haplois added 2 commits January 27, 2021 15:41

Peer review fixes

8bb540a

- Added `net20` and `net35` support to the code. - Other refactorings.

Peer review fixes batch 2

abf458c

AbhitejJohn approved these changes Jan 27, 2021

View reviewed changes

Haplois merged commit 9bcf509 into microsoft:master Jan 27, 2021

Haplois deleted the fqn-separation branch January 27, 2021 16:15

shyamnamboodiripad mentioned this pull request Mar 29, 2021

Tasks for fully qualified name #2833

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move FQN related code into a separate NuGet package #2714

Move FQN related code into a separate NuGet package #2714

Haplois commented Jan 24, 2021 •

edited

Loading

shyamnamboodiripad commented Jan 26, 2021

shyamnamboodiripad left a comment

shyamnamboodiripad Jan 26, 2021

shyamnamboodiripad Jan 27, 2021

Haplois commented Jan 27, 2021

AbhitejJohn left a comment

AbhitejJohn Jan 27, 2021

Haplois Jan 27, 2021

AbhitejJohn Jan 27, 2021

Haplois commented Jan 27, 2021 •

edited

Loading

AbhitejJohn commented Jan 27, 2021

Move FQN related code into a separate NuGet package #2714

Move FQN related code into a separate NuGet package #2714

Conversation

Haplois commented Jan 24, 2021 • edited Loading

Description

shyamnamboodiripad commented Jan 26, 2021

shyamnamboodiripad left a comment

Choose a reason for hiding this comment

shyamnamboodiripad Jan 26, 2021

Choose a reason for hiding this comment

shyamnamboodiripad Jan 27, 2021

Choose a reason for hiding this comment

Haplois commented Jan 27, 2021

AbhitejJohn left a comment

Choose a reason for hiding this comment

AbhitejJohn Jan 27, 2021

Choose a reason for hiding this comment

Haplois Jan 27, 2021

Choose a reason for hiding this comment

AbhitejJohn Jan 27, 2021

Choose a reason for hiding this comment

Haplois commented Jan 27, 2021 • edited Loading

AbhitejJohn commented Jan 27, 2021

Haplois commented Jan 24, 2021 •

edited

Loading

Haplois commented Jan 27, 2021 •

edited

Loading