For truly async calls we must maintain our lifetime #5199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yao-msft
previously approved these changes
Feb 12, 2025
yao-msft
approved these changes
Feb 12, 2025
JohnMcPMS
added a commit
to JohnMcPMS/winget-cli
that referenced
this pull request
Feb 12, 2025
## Change Add forgotten lifetime extension for async function. ## Validation Changed the sample caller to call `FindPackagesAsync`, then destroy the catalog object.
JohnMcPMS
added a commit
that referenced
this pull request
Feb 12, 2025
## Change Add forgotten lifetime extension for async function. ## Validation Changed the sample caller to call `FindPackagesAsync`, then destroy the catalog object. CP #5199
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Add forgotten lifetime extension for async function.
Validation
Changed the sample caller to call
FindPackagesAsync, then destroy the catalog object.Microsoft Reviewers: Open in CodeFlow